Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 2178553002: Rebaseline plugins/webview-plugin-lifecycle.html to verify flakiness status (Closed)

Created:
4 years, 5 months ago by Stephen Chennney
Modified:
4 years, 5 months ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline plugins/webview-plugin-lifecycle.html to verify flakiness status The test is marked as failing, but the baseline right now is clearly wrong, so maybe it's actually passing. TestExpectations may need to be re-added if it turns out to still be flakey. TBR=chrishtr@chromium.org BUG=526594 Committed: https://crrev.com/81de342072ef34eb4a316d24db17766eccf74db9 Cr-Commit-Position: refs/heads/master@{#407229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178553002/1
4 years, 5 months ago (2016-07-22 17:57:16 UTC) #2
chrishtr
lgtm
4 years, 5 months ago (2016-07-22 19:02:44 UTC) #3
chrishtr
FYI before he departed, leviw mentioned that the plugins/ directory is apparently disabled on most/all ...
4 years, 5 months ago (2016-07-22 19:03:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 19:20:27 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/81de342072ef34eb4a316d24db17766eccf74db9 Cr-Commit-Position: refs/heads/master@{#407229}
4 years, 5 months ago (2016-07-22 19:22:50 UTC) #7
Stephen Chennney
4 years, 5 months ago (2016-07-22 19:56:44 UTC) #8
Message was sent while issue was closed.
On 2016/07/22 19:03:34, chrishtr wrote:
> FYI before he departed, leviw mentioned that the plugins/ directory is
> apparently disabled
> on most/all platforms. Is that still the case, or has it been fixed? If it's
> still the case,
> we may need to move the actually-relevant plugin tests to another directory.

I thought they were disable too, but looking in all the expectations files I
can't find a skip line. Flakiness also shows linux results. So I'm guessing they
are now enabled.

Powered by Google App Engine
This is Rietveld 408576698