[Payments] Success Checkout Flow Funnel Metrics for Payment Request.

Implemented metrics to log the normal successful checkout flow in Payment Request:

Initiated,
Shown,
PayClicked,
ReceivedInstrumentDetails,
Completed.

BUG=631012
TEST=PaymentRequestMetricsTest

Committed: https://crrev.com/f80d59a0c4fd38d30e9e8d702abd98fba452f0f2
Cr-Commit-Position: refs/heads/master@{#408106}

[sebsg, 2016-07-22 22:46:01]

Description was changed from

==========
[Payment] Success Checkout Flow Funnel Metrics for Payment Request.

Implemented metrics to log the normal successful checkout flow in Payment
Request:

Initiated,
Shown,
PayClicked,
ReceivedInstrumentDetails,
Completed.

BUG=
==========

to

==========
Implemented metrics to log the normal successful checkout flow in Payment
Request:

Initiated,
Shown,
PayClicked,
ReceivedInstrumentDetails,
Completed.

BUG=
==========

[sebsg, 2016-07-25 12:49:32]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-07-25 13:11:28]

Patchset #1 (id:20001) has been deleted

[sebsg, 2016-07-25 13:15:39]

Description was changed from

==========
Implemented metrics to log the normal successful checkout flow in Payment
Request:

Initiated,
Shown,
PayClicked,
ReceivedInstrumentDetails,
Completed.

BUG=
==========

to

==========
Implemented metrics to log the normal successful checkout flow in Payment
Request:

Initiated,
Shown,
PayClicked,
ReceivedInstrumentDetails,
Completed.

BUG=631012
TEST=PaymentRequestMetricsTest
==========

[sebsg, 2016-07-25 13:15:40]

sebsg@chromium.org changed reviewers:
+ rouslan@chromium.org

[sebsg, 2016-07-25 13:16:49]

Hi Rouslan, PTAL?

[please use gerrit instead, 2016-07-25 17:44:00]

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1058:
* Records specific histograms related to the different steps of a successful
checkout.
+1 indent

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1059:
*/
+1 indent

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1061:
RecordHistogram.recordBooleanHistogram(
Do you think recordCountHistogram(string, 1) makes more sense here?

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
(right):

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java:55:
// Click the pay buttont.
button

https://codereview.chromium.org/2178463003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2178463003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:39012: +    When the browser retreives
the instrument details of the users to complete a
When the browser retrieves the instrument details from the payment app to
complete a purchase.

[sebsg, 2016-07-25 20:18:37]

Thanks for the comments, another look?

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1058:
* Records specific histograms related to the different steps of a successful
checkout.
On 2016/07/25 17:44:00, rouslan wrote:
> +1 indent

Done.

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1059:
*/
On 2016/07/25 17:44:00, rouslan wrote:
> +1 indent

Done.

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1061:
RecordHistogram.recordBooleanHistogram(
On 2016/07/25 17:44:00, rouslan wrote:
> Do you think recordCountHistogram(string, 1) makes more sense here?

The metrics team told me that a boolean is more efficient that an normal count
without restriction, which has buckets from 0 to 100 by default. I could do a
custom count histogram with only one bucket but I was told that boolean was the
conventional way to do this kind of logging.

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
(right):

https://codereview.chromium.org/2178463003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java:55:
// Click the pay buttont.
On 2016/07/25 17:44:00, rouslan wrote:
> button

Done.

https://codereview.chromium.org/2178463003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2178463003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:39012: +    When the browser retreives
the instrument details of the users to complete a
On 2016/07/25 17:44:00, rouslan wrote:
> When the browser retrieves the instrument details from the payment app to
> complete a purchase.

Done.

[please use gerrit instead, 2016-07-25 20:22:00]

lgtm

[sebsg, 2016-07-25 20:24:37]

sebsg@chromium.org changed reviewers:
+ jwd@chromium.org, yfriedman@chromium.org

[sebsg, 2016-07-25 20:24:37]

yfriedman@chromium.org: Could you please review PaymentRequestImpl.java and
PaymentRequestMetricsTest.java?

jwd@chromium.org: Could you please review histogram.xml?

Thanks!

[Yaron, 2016-07-25 21:59:49]

Not 100% sure how you use the metric (only true is ever recorded) - can you
clarify? Are you just seeing how many users reach each of the histograms? Could
use a histogram for counts?

https://codereview.chromium.org/2178463003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2178463003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:197:
recordSuccessFunnelHistograms("Initiated");
looks like native is guaranteed to be loaded (based on the referenced above) but
double-checking that's true.

[sebsg, 2016-07-25 22:29:25]

Boolean histograms are preferred for this kind of metric (counting the number of
times a specific event occurs).

There is a specific boolean enum (which I forgot to use initially) that exists
for specific cases like this:
https://cs.chromium.org/chromium/src/tools/metrics/histograms/histograms.xml?...

It's going to take a while to load. You can also open histograms.xml and search
for BooleanHit, the enum definition is the second to last.

Thanks!

https://codereview.chromium.org/2178463003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2178463003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:197:
recordSuccessFunnelHistograms("Initiated");
On 2016/07/25 21:59:49, Yaron wrote:
> looks like native is guaranteed to be loaded (based on the referenced above)
but
> double-checking that's true.

It serves a the starting point for the checkout flow funnel so basically, how
many people have started a Payment Request. It will be the base number which
will be used in subsequent analyses to figure out where users drop off of the
flow. That's why it's important for it to be there.

[jwd, 2016-07-26 20:19:43]

Histograms LGTM

[Yaron, 2016-07-27 11:31:47]

lgtm

[sebsg, 2016-07-27 12:20:17]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2016-07-27 12:20:17]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2178463003/#ps80001
(title: "Used more specfic BooleanHit enum type for histograms")

[commit-bot: I haz the power, 2016-07-27 12:20:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 13:15:17]

Description was changed from

==========
Implemented metrics to log the normal successful checkout flow in Payment
Request:

Initiated,
Shown,
PayClicked,
ReceivedInstrumentDetails,
Completed.

BUG=631012
TEST=PaymentRequestMetricsTest
==========

to

==========
Implemented metrics to log the normal successful checkout flow in Payment
Request:

Initiated,
Shown,
PayClicked,
ReceivedInstrumentDetails,
Completed.

BUG=631012
TEST=PaymentRequestMetricsTest
==========

[commit-bot: I haz the power, 2016-07-27 13:15:18]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-07-27 13:17:08]

Description was changed from

==========
Implemented metrics to log the normal successful checkout flow in Payment
Request:

Initiated,
Shown,
PayClicked,
ReceivedInstrumentDetails,
Completed.

BUG=631012
TEST=PaymentRequestMetricsTest
==========

to

==========
Implemented metrics to log the normal successful checkout flow in Payment
Request:

Initiated,
Shown,
PayClicked,
ReceivedInstrumentDetails,
Completed.

BUG=631012
TEST=PaymentRequestMetricsTest

Committed: https://crrev.com/f80d59a0c4fd38d30e9e8d702abd98fba452f0f2
Cr-Commit-Position: refs/heads/master@{#408106}
==========

[commit-bot: I haz the power, 2016-07-27 13:17:09]

Patchset 3 (id:??) landed as
https://crrev.com/f80d59a0c4fd38d30e9e8d702abd98fba452f0f2
Cr-Commit-Position: refs/heads/master@{#408106}