Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2178463002: Presentation API: clean up around usage of promises. (Closed)

Created:
4 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 5 months ago
Reviewers:
whywhat
CC:
blink-reviews, chromium-reviews, haraken, imcheng, mark a. foltz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Presentation API: clean up around usage of promises. I wrote this while investigating a Promise issue. I think it wouldn't hurt to land it :) BUG=None Committed: https://crrev.com/02e29a49876c306d27776ca186663cd147328e7b Cr-Commit-Position: refs/heads/master@{#407184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -40 lines) Patch
M third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp View 1 chunk +23 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mlamouri (slow - plz ping)
avayvod@, PTAL
4 years, 5 months ago (2016-07-22 14:39:41 UTC) #2
whywhat
lgtm
4 years, 5 months ago (2016-07-22 17:07:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178463002/1
4 years, 5 months ago (2016-07-22 17:09:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 17:13:36 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:16:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02e29a49876c306d27776ca186663cd147328e7b
Cr-Commit-Position: refs/heads/master@{#407184}

Powered by Google App Engine
This is Rietveld 408576698