Fix BlinkGC triggering so it is more sensitive to PartitionAlloc only allocations

Fix BlinkGC triggering so it is more sensitive to PartitionAlloc only allocations

We were not triggering a BlinkGC when partition alloc grew a lot but Oilpan heap allocated object size was small.

BUG=626082
Committed: https://crrev.com/9b5399503fe60d4939f60bfc5c6acd4131fe6208
Cr-Commit-Position: refs/heads/master@{#408102}

[haraken, 2016-07-26 14:40:50]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-07-26 14:40:51]

https://codereview.chromium.org/2178393002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/ThreadState.cpp (left):

https://codereview.chromium.org/2178393002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.cpp:511: #if
PRINT_HEAP_STATS

Shall we keep this line?

https://codereview.chromium.org/2178393002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right):

https://codereview.chromium.org/2178393002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.cpp:511: if
(partitionAllocGrowingRate() >= heapGrowingRateThreshold)

I'm a bit afraid of this change. After this change, won't we end up with
triggering Oilpan's GC when the renderer begins to run? (because at that point
the PartitionAlloc's growing rate would be high but Oilpan's memory usage is
quite low.)

[keishi, 2016-07-26 15:46:13]

https://codereview.chromium.org/2178393002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right):

https://codereview.chromium.org/2178393002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.cpp:511: if
(partitionAllocGrowingRate() >= heapGrowingRateThreshold)
On 2016/07/26 14:40:51, haraken wrote:
> 
> I'm a bit afraid of this change. After this change, won't we end up with
> triggering Oilpan's GC when the renderer begins to run? (because at that point
> the PartitionAlloc's growing rate would be high but Oilpan's memory usage is
> quite low.)
> 
> 

Yeah. I'm running the perf tests right now but it probably has a wider effect
than we want.
The html file from the bug is a memory pressure situation caused by partition
alloc so this new PS uses MemoryPressureGC to trigger the GC. I think the
probability of a negative impact is lower with this.

[keishi, 2016-07-27 08:11:08]

keishi@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org

[haraken, 2016-07-27 08:33:52]

Is PS2 ready for review?

[keishi, 2016-07-27 09:09:54]

On 2016/07/27 08:33:52, haraken wrote:
> Is PS2 ready for review?

Yes, PTAL.

[haraken, 2016-07-27 09:13:50]

LGTM

[keishi, 2016-07-27 10:07:21]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2016-07-27 10:07:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 12:39:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 12:41:15]

Description was changed from

==========
Fix BlinkGC triggering so it is more sensitive to PartitionAlloc only
allocations

We were not triggering a BlinkGC when partition alloc grew a lot but Oilpan heap
allocated object size was small.

BUG=626082
==========

to

==========
Fix BlinkGC triggering so it is more sensitive to PartitionAlloc only
allocations

We were not triggering a BlinkGC when partition alloc grew a lot but Oilpan heap
allocated object size was small.

BUG=626082

Committed: https://crrev.com/9b5399503fe60d4939f60bfc5c6acd4131fe6208
Cr-Commit-Position: refs/heads/master@{#408102}
==========

[commit-bot: I haz the power, 2016-07-27 12:41:16]

Patchset 2 (id:??) landed as
https://crrev.com/9b5399503fe60d4939f60bfc5c6acd4131fe6208
Cr-Commit-Position: refs/heads/master@{#408102}