Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2178363003: [debugging] Show internal fields with %DebugPrint (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugging] Show internal fields with %DebugPrint BUG= Committed: https://crrev.com/10474d18afc87a98a46ff9f56deca8df7595b05c Cr-Commit-Position: refs/heads/master@{#38061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/objects-printer.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Camillo Bruni
PTAL since I'm debugging the API this comes in handy :)
4 years, 4 months ago (2016-07-26 13:24:39 UTC) #2
Yang
lgtm
4 years, 4 months ago (2016-07-26 13:28:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178363003/1
4 years, 4 months ago (2016-07-26 14:58:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 15:24:39 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 15:27:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10474d18afc87a98a46ff9f56deca8df7595b05c
Cr-Commit-Position: refs/heads/master@{#38061}

Powered by Google App Engine
This is Rietveld 408576698