Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: ash/common/wm/overview/window_selector_item.cc

Issue 2178353006: [ash-md] Fixes z-order to get context menus above overview items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/common/wm/overview/window_selector.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/common/wm/overview/window_selector_item.h" 5 #include "ash/common/wm/overview/window_selector_item.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "ash/common/material_design/material_design_controller.h" 10 #include "ash/common/material_design/material_design_controller.h"
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 window_selector_(window_selector) { 284 window_selector_(window_selector) {
285 CreateWindowLabel(window->GetTitle()); 285 CreateWindowLabel(window->GetTitle());
286 if (!ash::MaterialDesignController::IsOverviewMaterial()) { 286 if (!ash::MaterialDesignController::IsOverviewMaterial()) {
287 views::Widget::InitParams params; 287 views::Widget::InitParams params;
288 params.type = views::Widget::InitParams::TYPE_POPUP; 288 params.type = views::Widget::InitParams::TYPE_POPUP;
289 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; 289 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
290 params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW; 290 params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
291 close_button_widget_.reset(new views::Widget); 291 close_button_widget_.reset(new views::Widget);
292 close_button_widget_->set_focus_on_creation(false); 292 close_button_widget_->set_focus_on_creation(false);
293 window->GetRootWindowController()->ConfigureWidgetInitParamsForContainer( 293 window->GetRootWindowController()->ConfigureWidgetInitParamsForContainer(
294 close_button_widget_.get(), kShellWindowId_OverlayContainer, &params); 294 close_button_widget_.get(), kShellWindowId_StatusContainer, &params);
295 close_button_widget_->Init(params); 295 close_button_widget_->Init(params);
296 close_button_->SetVisible(false); 296 close_button_->SetVisible(false);
297 close_button_widget_->SetContentsView(close_button_); 297 close_button_widget_->SetContentsView(close_button_);
298 close_button_widget_->SetSize(close_button_->GetPreferredSize()); 298 close_button_widget_->SetSize(close_button_->GetPreferredSize());
299 close_button_widget_->Show(); 299 close_button_widget_->Show();
300 300
301 gfx::Rect close_button_rect(close_button_->GetPreferredSize()); 301 gfx::Rect close_button_rect(close_button_->GetPreferredSize());
302 // Align the center of the button with position (0, 0) so that the 302 // Align the center of the button with position (0, 0) so that the
303 // translate transform does not need to take the button dimensions into 303 // translate transform does not need to take the button dimensions into
304 // account. 304 // account.
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
509 const bool material = ash::MaterialDesignController::IsOverviewMaterial(); 509 const bool material = ash::MaterialDesignController::IsOverviewMaterial();
510 window_label_.reset(new views::Widget); 510 window_label_.reset(new views::Widget);
511 views::Widget::InitParams params; 511 views::Widget::InitParams params;
512 params.type = views::Widget::InitParams::TYPE_POPUP; 512 params.type = views::Widget::InitParams::TYPE_POPUP;
513 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; 513 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
514 params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW; 514 params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
515 params.visible_on_all_workspaces = true; 515 params.visible_on_all_workspaces = true;
516 window_label_->set_focus_on_creation(false); 516 window_label_->set_focus_on_creation(false);
517 root_window_->GetRootWindowController() 517 root_window_->GetRootWindowController()
518 ->ConfigureWidgetInitParamsForContainer( 518 ->ConfigureWidgetInitParamsForContainer(
519 window_label_.get(), kShellWindowId_OverlayContainer, &params); 519 window_label_.get(), kShellWindowId_StatusContainer, &params);
520 window_label_->Init(params); 520 window_label_->Init(params);
521 window_label_button_view_ = new OverviewLabelButton(this, title); 521 window_label_button_view_ = new OverviewLabelButton(this, title);
522 window_label_button_view_->SetBorder(views::Border::NullBorder()); 522 window_label_button_view_->SetBorder(views::Border::NullBorder());
523 window_label_button_view_->SetEnabledTextColors(kLabelColor); 523 window_label_button_view_->SetEnabledTextColors(kLabelColor);
524 window_label_button_view_->set_animate_on_state_change(false); 524 window_label_button_view_->set_animate_on_state_change(false);
525 if (material) { 525 if (material) {
526 window_label_button_view_->SetHorizontalAlignment(gfx::ALIGN_LEFT); 526 window_label_button_view_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
527 } else { 527 } else {
528 window_label_button_view_->SetHorizontalAlignment(gfx::ALIGN_CENTER); 528 window_label_button_view_->SetHorizontalAlignment(gfx::ALIGN_CENTER);
529 window_label_button_view_->SetTextShadows(gfx::ShadowValues( 529 window_label_button_view_->SetTextShadows(gfx::ShadowValues(
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
639 window_label_selector_window->SetOpacity(opacity); 639 window_label_selector_window->SetOpacity(opacity);
640 } 640 }
641 641
642 void WindowSelectorItem::UpdateCloseButtonAccessibilityName() { 642 void WindowSelectorItem::UpdateCloseButtonAccessibilityName() {
643 close_button_->SetAccessibleName(l10n_util::GetStringFUTF16( 643 close_button_->SetAccessibleName(l10n_util::GetStringFUTF16(
644 IDS_ASH_OVERVIEW_CLOSE_ITEM_BUTTON_ACCESSIBLE_NAME, 644 IDS_ASH_OVERVIEW_CLOSE_ITEM_BUTTON_ACCESSIBLE_NAME,
645 GetWindow()->GetTitle())); 645 GetWindow()->GetTitle()));
646 } 646 }
647 647
648 } // namespace ash 648 } // namespace ash
OLDNEW
« no previous file with comments | « ash/common/wm/overview/window_selector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698