Remove use of MakeRenderTargetDirect from view system

Remove use of MakeRenderTargetDirect from view system

Here is the CL that sent me down the SkGammaColorFilter path

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178353005

Committed: https://skia.googlesource.com/skia/+/ecf3dbe8f2987a08b21be1aff61b7fbfbb69640a

[robertphillips, 2016-07-26 18:17:45]

Description was changed from

==========
Remove use of MakeRenderTargetDirect from view system
==========

to

==========
Remove use of MakeRenderTargetDirect from view system
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178353005
==========

[robertphillips, 2016-07-27 15:57:33]

Description was changed from

==========
Remove use of MakeRenderTargetDirect from view system
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178353005
==========

to

==========
Remove use of MakeRenderTargetDirect from view system

Here is the CL that sent me down the SkGammaColorFilter path

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178353005
==========

[robertphillips, 2016-07-27 15:57:33]

robertphillips@google.com changed reviewers:
+ brianosman@google.com, bsalomon@google.com

[bsalomon, 2016-07-27 16:01:19]

On 2016/07/27 15:57:42, robertphillips wrote:

Seems like an improvement to me, though I'd like to delete every file changed in
this CL ASAP :)

[robertphillips, 2016-07-27 16:10:30]

On 2016/07/27 16:01:19, bsalomon wrote:
> On 2016/07/27 15:57:42, robertphillips wrote:
> 
> Seems like an improvement to me, though I'd like to delete every file changed
in
> this CL ASAP :)

I agree but I don't want to be held up until SampleApp is removed (and this
doesn't seem that heinous a change).

It is, however, blocked on how we can accomplish applyGamma at the
SkSurface/SkCanvas level.

[bsalomon, 2016-07-27 17:23:28]

On 2016/07/27 16:10:30, robertphillips wrote:
> On 2016/07/27 16:01:19, bsalomon wrote:
> > On 2016/07/27 15:57:42, robertphillips wrote:
> > 
> > Seems like an improvement to me, though I'd like to delete every file
changed
> in
> > this CL ASAP :)
> 
> I agree but I don't want to be held up until SampleApp is removed (and this
> doesn't seem that heinous a change).
> 
> It is, however, blocked on how we can accomplish applyGamma at the
> SkSurface/SkCanvas level.

Sure, I don't have a strong preference for either approach. If Mike doesn't
object to the color filter approach then that's ok with me.

[robertphillips, 2016-07-28 16:35:20]

Patchset #6 (id:100001) has been deleted

[robertphillips, 2016-07-28 17:24:06]

PTAL. I've updated this so it sets the stage for replacing applyGamma with a
SkCanvas::drawImage.

[robertphillips, 2016-07-28 17:44:21]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 17:44:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsalomon, 2016-07-28 17:44:46]

lgtm

[commit-bot: I haz the power, 2016-07-28 17:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 17:51:34]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[robertphillips, 2016-07-28 18:47:59]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 18:48:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 18:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 18:55:21]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[robertphillips, 2016-07-28 19:10:50]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 19:10:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 19:57:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 19:57:05]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-28 22:16:36]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-07-28 22:16:36]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2178353005/#ps160001
(title: "Fix Mac")

[commit-bot: I haz the power, 2016-07-28 22:16:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 22:17:37]

Description was changed from

==========
Remove use of MakeRenderTargetDirect from view system

Here is the CL that sent me down the SkGammaColorFilter path

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178353005
==========

to

==========
Remove use of MakeRenderTargetDirect from view system

Here is the CL that sent me down the SkGammaColorFilter path

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178353005

Committed:
https://skia.googlesource.com/skia/+/ecf3dbe8f2987a08b21be1aff61b7fbfbb69640a
==========

[commit-bot: I haz the power, 2016-07-28 22:17:38]

Committed patchset #8 (id:160001) as
https://skia.googlesource.com/skia/+/ecf3dbe8f2987a08b21be1aff61b7fbfbb69640a