compile.py: Don't set OFFICIAL_BUILD for --mode=official builds.

compile.py: Don't set OFFICIAL_BUILD for --mode=official builds.

As far as I can tell, no internal or external script looks at this env var
(there are several that look at CHROME_BUILD_TYPE though, which OFFICIAL_BUILD
is redundant with). This env var was added long ago (it was in initial.commit
and has only been moved around since), so it's probably no longer needed.

BUG=330631
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=261561

[Nico, 2014-04-03 18:50:53]

(+ a few more people who might know things about initial.commit.)

[mmoss, 2014-04-03 19:02:27]

On 2014/04/03 18:50:53, Nico wrote:
> (+ a few more people who might know things about initial.commit.)

There has always been a lot of overlap in these flags, leading to a lot of
confusion about what controlled what, so +1 to any cleanup. I'm sure at some
point there was something keyed off this one, but I also can no longer find any
reference to it, so I think it's safe to remove.

[Lei Zhang, 2014-04-03 22:21:36]

So OFFICIAL_BUILD will still remain defined, and it's just the environment
variable that will no longer be set? I didn't find any users of the env var
either.

FYI, build/android/envsetup.sh still sets this env var.

[Nico, 2014-04-03 22:25:10]

On 2014/04/03 22:21:36, Lei Zhang wrote:
> So OFFICIAL_BUILD will still remain defined

The preprocessor define? Yes.

>, and it's just the environment
> variable that will no longer be set? I didn't find any users of the env var
> either.
> 
> FYI, build/android/envsetup.sh still sets this env var.

No, I deleted that today (which is why I'm looking at this.) (The internal
android waterfall sets it atm, but I'll undo that once this is in.)

[Lei Zhang, 2014-04-03 22:45:44]

Unless someone finds a need for this and hollers, I'd say lgtm.

[Nico, 2014-04-03 22:53:33]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-04-03 22:54:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/217833006/1

[commit-bot: I haz the power, 2014-04-03 22:55:44]

Change committed as 261561