chrome/browser/resources/settings/people_page/people_page.html - Issue 2178303003: MD Settings: disable cursor: pointer when sync is disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2178303003: MD Settings: disable cursor: pointer when sync is disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tommycli@ review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/people_page/people_page.html

diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html

index dc19175001f7b5346a3fbba0f4f875015f776250..454eec62ef0dbf04bd58c651ecfb6880c9085f72 100644

--- a/chrome/browser/resources/settings/people_page/people_page.html

+++ b/chrome/browser/resources/settings/people_page/people_page.html

@@ -125,7 +125,8 @@

<template is="dom-if"

if="[[isAdvancedSyncSettingsVisible_(syncStatus)]]">

Dan Beam 2016/07/29 03:45:05 this requires a non-null syncStatus, so I've simpl

tommycli 2016/07/29 15:48:08 Thanks!

- <div class="settings-box two-line" on-tap="onSyncTap_" actionable>

+ <div class="settings-box two-line" on-tap="onSyncTap_"

+ actionable$="[[!isSyncManaged_(syncStatus)]]">

<iron-icon id="sync-icon" icon$="[[getSyncIcon_(syncStatus)]]">

</iron-icon>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »