Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2178263003: [DevTools] Fix function property preview in ObjectPropertySection (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
dgozman, lushnikov, luoe
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix function property preview in ObjectPropertySection Without patch regexp could be matched to function declaration inside of comment. BUG=621387 R=luoe@chromium.org,lushnikov@chromium.org Committed: https://crrev.com/315221fd016a876336d25c4043e0d28a7c45df34 Cr-Commit-Position: refs/heads/master@{#407895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-dir-es6.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-es6-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
kozy
Erik and Andrey, please take a look!
4 years, 4 months ago (2016-07-26 18:28:57 UTC) #2
luoe
On 2016/07/26 18:28:57, kozyatinskiy wrote: > Erik and Andrey, please take a look! LGTM
4 years, 4 months ago (2016-07-26 18:35:26 UTC) #3
dgozman
lgtm
4 years, 4 months ago (2016-07-26 19:19:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178263003/1
4 years, 4 months ago (2016-07-26 19:21:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 20:10:18 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 20:14:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/315221fd016a876336d25c4043e0d28a7c45df34
Cr-Commit-Position: refs/heads/master@{#407895}

Powered by Google App Engine
This is Rietveld 408576698