Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2178263002: Add ExecutionContext and ScriptState support to blink::TaskRunnerHelper (Closed)

Created:
4 years, 4 months ago by tzik
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ExecutionContext and ScriptState support to blink::TaskRunnerHelper Many of users of TaskRunnerHelper have ExecutionContext or ScriptState rather than Document or Frame, which are a few step away from EC or SS. This CL add overloads of TaskRunnerHelper::getUnthrottledTaskRunner for EC and SS for shorthand. BUG=624696 Committed: https://crrev.com/cce066dfc6c0825999730afcaba4d8b9c0beaa37 Cr-Commit-Position: refs/heads/master@{#407721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tzik
PTAL
4 years, 4 months ago (2016-07-26 05:02:32 UTC) #5
haraken
LGTM You can add similar methods for getLoadingTaskRunner and getTimerTaskRunner.
4 years, 4 months ago (2016-07-26 05:35:01 UTC) #7
tzik
On 2016/07/26 05:35:01, haraken wrote: > LGTM > > You can add similar methods for ...
4 years, 4 months ago (2016-07-26 05:52:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178263002/1
4 years, 4 months ago (2016-07-26 05:52:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 06:03:20 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 06:04:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cce066dfc6c0825999730afcaba4d8b9c0beaa37
Cr-Commit-Position: refs/heads/master@{#407721}

Powered by Google App Engine
This is Rietveld 408576698