Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Side by Side Diff: src/variables.cc

Issue 217823003: Make invalid LHSs that are calls late errors (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/variables.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 case TEMPORARY: return "TEMPORARY"; 51 case TEMPORARY: return "TEMPORARY";
52 } 52 }
53 UNREACHABLE(); 53 UNREACHABLE();
54 return NULL; 54 return NULL;
55 } 55 }
56 56
57 57
58 Variable::Variable(Scope* scope, 58 Variable::Variable(Scope* scope,
59 Handle<String> name, 59 Handle<String> name,
60 VariableMode mode, 60 VariableMode mode,
61 bool is_valid_LHS, 61 bool is_valid_ref,
62 Kind kind, 62 Kind kind,
63 InitializationFlag initialization_flag, 63 InitializationFlag initialization_flag,
64 Interface* interface) 64 Interface* interface)
65 : scope_(scope), 65 : scope_(scope),
66 name_(name), 66 name_(name),
67 mode_(mode), 67 mode_(mode),
68 kind_(kind), 68 kind_(kind),
69 location_(UNALLOCATED), 69 location_(UNALLOCATED),
70 index_(-1), 70 index_(-1),
71 initializer_position_(RelocInfo::kNoPosition), 71 initializer_position_(RelocInfo::kNoPosition),
72 local_if_not_shadowed_(NULL), 72 local_if_not_shadowed_(NULL),
73 is_valid_LHS_(is_valid_LHS), 73 is_valid_ref_(is_valid_ref),
74 force_context_allocation_(false), 74 force_context_allocation_(false),
75 is_used_(false), 75 is_used_(false),
76 initialization_flag_(initialization_flag), 76 initialization_flag_(initialization_flag),
77 interface_(interface) { 77 interface_(interface) {
78 // Names must be canonicalized for fast equality checks. 78 // Names must be canonicalized for fast equality checks.
79 ASSERT(name->IsInternalizedString()); 79 ASSERT(name->IsInternalizedString());
80 // Var declared variables never need initialization. 80 // Var declared variables never need initialization.
81 ASSERT(!(mode == VAR && initialization_flag == kNeedsInitialization)); 81 ASSERT(!(mode == VAR && initialization_flag == kNeedsInitialization));
82 } 82 }
83 83
84 84
85 bool Variable::IsGlobalObjectProperty() const { 85 bool Variable::IsGlobalObjectProperty() const {
86 // Temporaries are never global, they must always be allocated in the 86 // Temporaries are never global, they must always be allocated in the
87 // activation frame. 87 // activation frame.
88 return (IsDynamicVariableMode(mode_) || 88 return (IsDynamicVariableMode(mode_) ||
89 (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_))) 89 (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_)))
90 && scope_ != NULL && scope_->is_global_scope(); 90 && scope_ != NULL && scope_->is_global_scope();
91 } 91 }
92 92
93 93
94 int Variable::CompareIndex(Variable* const* v, Variable* const* w) { 94 int Variable::CompareIndex(Variable* const* v, Variable* const* w) {
95 int x = (*v)->index(); 95 int x = (*v)->index();
96 int y = (*w)->index(); 96 int y = (*w)->index();
97 // Consider sorting them according to type as well? 97 // Consider sorting them according to type as well?
98 return x - y; 98 return x - y;
99 } 99 }
100 100
101 } } // namespace v8::internal 101 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/variables.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698