Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h

Issue 2178223002: Refactor Worklet class to use ScriptResource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add tests, DCHECK(frame) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
diff --git a/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h b/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
index eb966b5434906f9d2c2812f2f23b2ad859ddd752..ef78ba0fabce0e37677da51bb68cd1f8a96f306a 100644
--- a/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
+++ b/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
@@ -15,6 +15,7 @@ namespace blink {
class ConsoleMessage;
class LocalFrame;
+class ScriptSourceCode;
class CORE_EXPORT MainThreadWorkletGlobalScope : public WorkletGlobalScope, public WorkletGlobalScopeProxy, public LocalFrameLifecycleObserver {
public:
@@ -22,7 +23,7 @@ public:
bool isMainThreadWorkletGlobalScope() const final { return true; }
// WorkletGlobalScopeProxy
- void evaluateScript(const String& source, const KURL& scriptURL) final;
+ void evaluateScript(const ScriptSourceCode&) final;
ikilpatrick 2016/07/28 00:12:44 I'm not sure we should do this, can a ScriptSource
haraken 2016/07/28 08:52:05 ScriptSourceCode is not transferrable unfortunatel
ikilpatrick 2016/07/28 18:48:41 Gleb and I talked in person, agreed that we'll pas
void terminateWorkletGlobalScope() final;
using LocalFrameLifecycleObserver::frame;

Powered by Google App Engine
This is Rietveld 408576698