third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp - Issue 2178223002: Refactor Worklet class to use ScriptResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

Issue 2178223002: Refactor Worklet class to use ScriptResource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add tests, DCHECK(frame) Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h ('K') | « third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h ('k') | third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h » ('j') | third_party/WebKit/Source/modules/worklet/Worklet.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp b/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

index 1d605348e21831c265ecd30b9191f553acefb3be..707e849c7b2dff29df18406e0fda42ca1d9531d4 100644

--- a/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp

@@ -21,9 +21,9 @@ MainThreadWorkletGlobalScope::~MainThreadWorkletGlobalScope()

{

}

-void MainThreadWorkletGlobalScope::evaluateScript(const String& source, const KURL& scriptURL)

+void MainThreadWorkletGlobalScope::evaluateScript(const ScriptSourceCode& scriptSourceCode)

{

- scriptController()->evaluate(ScriptSourceCode(source, scriptURL));

+ scriptController()->evaluate(scriptSourceCode);

}

void MainThreadWorkletGlobalScope::terminateWorkletGlobalScope()