Refactor Worklet class to use ScriptResource

Refactor Worklet class to use ScriptResource.

Following the recommendations discussed in http://crrev.com/2146633002, this patch switches Worklet.cpp to use ScriptResource to load a worklet script, so it can follow the code path defined in FrameFetchContext::canRequest for CSP checks.

BUG=567358
Committed: https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f
Cr-Commit-Position: refs/heads/master@{#409232}

[ikilpatrick, 2016-07-26 18:16:53]

ikilpatrick@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[ikilpatrick, 2016-07-26 18:16:54]

https://codereview.chromium.org/2178223002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/modules.gypi (right):

https://codereview.chromium.org/2178223002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/modules.gypi:1979:
'worklet/WorkletScriptLoader.cpp',
missing file from patch?

[Gleb Lanbin, 2016-07-26 18:29:23]

https://codereview.chromium.org/2178223002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/modules.gypi (right):

https://codereview.chromium.org/2178223002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/modules.gypi:1979:
'worklet/WorkletScriptLoader.cpp',
On 2016/07/26 18:16:54, ikilpatrick wrote:
> missing file from patch?

Done.

[yhirano, 2016-07-27 09:09:40]

yhirano@chromium.org changed reviewers:
+ yhirano@chromium.org

[yhirano, 2016-07-27 09:09:46]

https://codereview.chromium.org/2178223002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.h (right):

https://codereview.chromium.org/2178223002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.h:41: explicit
Worklet(ExecutionContext*, LocalFrame*);
Could you tell me when the frame is null?

[Gleb Lanbin, 2016-07-27 23:20:28]

Description was changed from

==========
WIP: Refactor Worklet class to use ScriptResource.

BUG=
==========

to

==========
Refactor Worklet class to use ScriptResource.

Following the recommendations discussed in http://crrev.com/2146633002, this
patch switches Worklet.cpp to use ScriptResource to load a worklet script, so it
can follow the code path defined in FrameFetchContext::canRequest for CSP
checks.

BUG=567358
==========

[Gleb Lanbin, 2016-07-27 23:20:28]

glebl@chromium.org changed reviewers:
+ mkwst@chromium.org

[Gleb Lanbin, 2016-07-27 23:21:17]

On 2016/07/27 09:09:46, yhirano wrote:
>
https://codereview.chromium.org/2178223002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/worklet/Worklet.h (right):
> 
>
https://codereview.chromium.org/2178223002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/worklet/Worklet.h:41: explicit
> Worklet(ExecutionContext*, LocalFrame*);
> Could you tell me when the frame is null?

discussed it with Ian, you're right, the frame can not be null here. updated.

[ikilpatrick, 2016-07-28 00:12:44]

https://codereview.chromium.org/2178223002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.cpp (right):

https://codereview.chromium.org/2178223002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.cpp:1: 
missing copyright.

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
(right):

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h:26: void
evaluateScript(const ScriptSourceCode&) final;
I'm not sure we should do this, can a ScriptSourceCode be transferred across
threads?

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.cpp (right):

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.cpp:1: 
copyright.

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.cpp:14: :
m_resolver(resolver), m_host(worklet),
m_workletGlobalScopeProxy(workletGlobalScopeProxy)
: m_x
, m_y

style to be consistent within blink.

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h (right):

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h:1: #ifndef
WorkletScriptLoader_h
copyright.

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h:31: void
notifyFinished(Resource*) override;
s/override/final & elsewhere.

[haraken, 2016-07-28 08:52:05]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-07-28 08:52:06]

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
(right):

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h:26: void
evaluateScript(const ScriptSourceCode&) final;
On 2016/07/28 00:12:44, ikilpatrick wrote:
> I'm not sure we should do this, can a ScriptSourceCode be transferred across
> threads?

ScriptSourceCode is not transferrable unfortunately.

[yhirano, 2016-07-28 14:41:10]

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.cpp (right):

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:27: m_fetcher =
ResourceFetcher::create(/* context */ nullptr);
I still don't understand why we need to create a ResourceFetcher.

[ikilpatrick, 2016-07-28 18:48:41]

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
(right):

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h:26: void
evaluateScript(const ScriptSourceCode&) final;
On 2016/07/28 08:52:05, haraken wrote:
> On 2016/07/28 00:12:44, ikilpatrick wrote:
> > I'm not sure we should do this, can a ScriptSourceCode be transferred across
> > threads?
> 
> ScriptSourceCode is not transferrable unfortunately.

Gleb and I talked in person, agreed that we'll pass this object through for
MainThreadWorklet and the ThreadedWorkletGlobalScopeProxy will grab the
components to transfer across to the thread.

[Gleb Lanbin, 2016-07-28 20:43:29]

PTAL

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.cpp (right):

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:27: m_fetcher =
ResourceFetcher::create(/* context */ nullptr);
On 2016/07/28 14:41:10, yhirano wrote:
> I still don't understand why we need to create a ResourceFetcher.

done.

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.cpp (right):

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.cpp:1: 
On 2016/07/28 00:12:44, ikilpatrick wrote:
> copyright.

Done.

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.cpp:14: :
m_resolver(resolver), m_host(worklet),
m_workletGlobalScopeProxy(workletGlobalScopeProxy)
On 2016/07/28 00:12:44, ikilpatrick wrote:
> : m_x
> , m_y
> 
> style to be consistent within blink.

Done.

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h (right):

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h:1: #ifndef
WorkletScriptLoader_h
On 2016/07/28 00:12:44, ikilpatrick wrote:
> copyright.

Done.

https://codereview.chromium.org/2178223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h:31: void
notifyFinished(Resource*) override;
On 2016/07/28 00:12:44, ikilpatrick wrote:
> s/override/final & elsewhere.

Done.

[ikilpatrick, 2016-07-28 22:42:10]

lgtm but obviously wait for mike and either haraken or yhirano :)

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.cpp (right):

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:28: KURL scriptURL =
getExecutionContext()->completeURL(url);
should we still do the scriptURL isValid up front here to provide additional
debug info to authors?

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:59: for (auto resource :
m_resources) {
auto& ?

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h (right):

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h:40:
WorkletGlobalScopeProxy* m_workletGlobalScopeProxy;
I wouldn't store this here just access it through the worklet.

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h:42:
WTF_MAKE_NONCOPYABLE(WorkletScriptLoader);
typically goes after USING_GAR...etc.

[Gleb Lanbin, 2016-07-29 01:40:23]

thanks for the review.

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.cpp (right):

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:28: KURL scriptURL =
getExecutionContext()->completeURL(url);
On 2016/07/28 22:42:10, ikilpatrick wrote:
> should we still do the scriptURL isValid up front here to provide additional
> debug info to authors?

Done.

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:59: for (auto resource :
m_resources) {
On 2016/07/28 22:42:10, ikilpatrick wrote:
> auto& ?

Done.

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h (right):

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h:40:
WorkletGlobalScopeProxy* m_workletGlobalScopeProxy;
On 2016/07/28 22:42:10, ikilpatrick wrote:
> I wouldn't store this here just access it through the worklet.

Done.

https://codereview.chromium.org/2178223002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h:42:
WTF_MAKE_NONCOPYABLE(WorkletScriptLoader);
On 2016/07/28 22:42:10, ikilpatrick wrote:
> typically goes after USING_GAR...etc.

Done.

[yhirano, 2016-07-29 02:19:23]

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.cpp (right):

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:21:
Worklet::Worklet(ExecutionContext* executionContext, LocalFrame* frame)
Can you tell me the relationship between |frame| and |executionContext|? Does
|frame->document()| always equal to |executionContext|? If so, can we omit the
|executionContext| parameter? Otherwise, when will they be different each other?

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:44:
resource->addClient(workletLoader);
You need to remove the client manually from the resource before the client gets
invalid. Inheriting from ResourceOwner is the simplest way to address it, I
guess.

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:44:
resource->addClient(workletLoader);
resource -> workerLoader is a weak reference (actually, held as a raw pointer).
I think |workerLoader| is held by no one, right?

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:56: DCHECK(index !=
kNotFound);
DCHECK_NE

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:57:
DCHECK(m_resources[index] == resource);
DCHECK_EQ

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.h (right):

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.h:18: class ExecutionContext;
+class Resource;

[haraken, 2016-07-29 08:26:35]

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.cpp (right):

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:21:
Worklet::Worklet(ExecutionContext* executionContext, LocalFrame* frame)
On 2016/07/29 02:19:23, yhirano wrote:
> Can you tell me the relationship between |frame| and |executionContext|? Does
> |frame->document()| always equal to |executionContext|? If so, can we omit the
> |executionContext| parameter? Otherwise, when will they be different each
other?

It should be. If the two are different, you're doing a wrong thing :)

So you should be able to remove either of the ExecutionContext or LocalFrame.

[Gleb Lanbin, 2016-07-29 19:23:14]

PTAL

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.cpp (right):

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:21:
Worklet::Worklet(ExecutionContext* executionContext, LocalFrame* frame)
On 2016/07/29 08:26:35, haraken wrote:
> On 2016/07/29 02:19:23, yhirano wrote:
> > Can you tell me the relationship between |frame| and |executionContext|?
Does
> > |frame->document()| always equal to |executionContext|? If so, can we omit
the
> > |executionContext| parameter? Otherwise, when will they be different each
> other?
> 
> It should be. If the two are different, you're doing a wrong thing :)
> 
> So you should be able to remove either of the ExecutionContext or LocalFrame.

Done.

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:44:
resource->addClient(workletLoader);
On 2016/07/29 02:19:23, yhirano wrote:
> resource -> workerLoader is a weak reference (actually, held as a raw
pointer).
> I think |workerLoader| is held by no one, right?

Done. Thanks!

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:44:
resource->addClient(workletLoader);
On 2016/07/29 02:19:23, yhirano wrote:
> You need to remove the client manually from the resource before the client
gets
> invalid. Inheriting from ResourceOwner is the simplest way to address it, I
> guess.

Done.

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:56: DCHECK(index !=
kNotFound);
On 2016/07/29 02:19:23, yhirano wrote:
> DCHECK_NE

Done.

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.cpp:57:
DCHECK(m_resources[index] == resource);
On 2016/07/29 02:19:23, yhirano wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/worklet/Worklet.h (right):

https://codereview.chromium.org/2178223002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/worklet/Worklet.h:18: class ExecutionContext;
On 2016/07/29 02:19:23, yhirano wrote:
> +class Resource;

Done.

[yhirano, 2016-08-01 10:56:28]

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
(right):

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h:29:
AnimationWorklet(LocalFrame*);
+explicit

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/csspaint/PaintWorklet.h (right):

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/csspaint/PaintWorklet.h:31:
PaintWorklet(LocalFrame*);
+explicit

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/worklet/Worklet.h (right):

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/worklet/Worklet.h:48:
HeapVector<Member<Resource>> m_resources;
It seems having m_resources is not necessary if we

- add cancel() to WorkletScriptLoader,
- call WorkletScriptLoader::cancel in stop(), and
- make notifyFinished take WorkerScriptLoader*, not Resource*.

Does that make sense?

It also allows us to make m_scriptLoaders a
HeapHashSet<Member<WorkletScriptLoader>>.

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h (right):

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h:15: class
ScriptPromiseResolver;
Not needed as you are including the header file.

[Gleb Lanbin, 2016-08-01 19:49:51]

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
(right):

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h:29:
AnimationWorklet(LocalFrame*);
On 2016/08/01 10:56:27, yhirano wrote:
> +explicit

Done.

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/csspaint/PaintWorklet.h (right):

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/csspaint/PaintWorklet.h:31:
PaintWorklet(LocalFrame*);
On 2016/08/01 10:56:28, yhirano wrote:
> +explicit

Done.

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/worklet/Worklet.h (right):

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/worklet/Worklet.h:48:
HeapVector<Member<Resource>> m_resources;
On 2016/08/01 10:56:28, yhirano wrote:
> It seems having m_resources is not necessary if we
> 
> - add cancel() to WorkletScriptLoader,
> - call WorkletScriptLoader::cancel in stop(), and
> - make notifyFinished take WorkerScriptLoader*, not Resource*.
> 
> Does that make sense?
> 
> It also allows us to make m_scriptLoaders a
> HeapHashSet<Member<WorkletScriptLoader>>.

Done.

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h (right):

https://codereview.chromium.org/2178223002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h:15: class
ScriptPromiseResolver;
On 2016/08/01 10:56:28, yhirano wrote:
> Not needed as you are including the header file.

Done.

[yhirano, 2016-08-01 22:35:27]

lgtm

[haraken, 2016-08-02 04:04:49]

LGTM

[Mike West, 2016-08-02 07:37:00]

LGTM 4. Thanks!

[Gleb Lanbin, 2016-08-02 16:18:18]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-08-02 16:18:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org, haraken@chromium.org, mkwst@chromium.org,
yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2178223002/#ps140001
(title: "synced to the head")

[commit-bot: I haz the power, 2016-08-02 16:18:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 17:50:43]

Description was changed from

==========
Refactor Worklet class to use ScriptResource.

Following the recommendations discussed in http://crrev.com/2146633002, this
patch switches Worklet.cpp to use ScriptResource to load a worklet script, so it
can follow the code path defined in FrameFetchContext::canRequest for CSP
checks.

BUG=567358
==========

to

==========
Refactor Worklet class to use ScriptResource.

Following the recommendations discussed in http://crrev.com/2146633002, this
patch switches Worklet.cpp to use ScriptResource to load a worklet script, so it
can follow the code path defined in FrameFetchContext::canRequest for CSP
checks.

BUG=567358
==========

[commit-bot: I haz the power, 2016-08-02 17:50:46]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-08-02 17:53:29]

Description was changed from

==========
Refactor Worklet class to use ScriptResource.

Following the recommendations discussed in http://crrev.com/2146633002, this
patch switches Worklet.cpp to use ScriptResource to load a worklet script, so it
can follow the code path defined in FrameFetchContext::canRequest for CSP
checks.

BUG=567358
==========

to

==========
Refactor Worklet class to use ScriptResource.

Following the recommendations discussed in http://crrev.com/2146633002, this
patch switches Worklet.cpp to use ScriptResource to load a worklet script, so it
can follow the code path defined in FrameFetchContext::canRequest for CSP
checks.

BUG=567358

Committed: https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f
Cr-Commit-Position: refs/heads/master@{#409232}
==========

[commit-bot: I haz the power, 2016-08-02 17:53:30]

Patchset 8 (id:??) landed as
https://crrev.com/b456ae94c7e484d0ad50584333914c1e1b5f462f
Cr-Commit-Position: refs/heads/master@{#409232}