chrome/browser/permissions/permission_uma_util.cc - Issue 2178213003: Update RequestTrigger to GestureType in permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2178213003: Update RequestTrigger to GestureType in permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/permissions/permission_uma_util.cc

diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc

index 4697e8d58fc9e550242e4d28f1e2ad72f7f0d35c..69b0d60cf649047ae72bc91c12d23184c3b797ad 100644

--- a/chrome/browser/permissions/permission_uma_util.cc

+++ b/chrome/browser/permissions/permission_uma_util.cc

@@ -389,7 +389,8 @@ void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,

g_browser_process->safe_browsing_service()

->ui_manager()

->ReportPermissionAction(requesting_origin, permission, action,

- source_ui, false /* user_gesture */);

+ source_ui,

+ PermissionRequestGestureType::UNKNOWN);

kcarattini 2016/07/26 06:03:26 Why not "unspecified" like the report type?

stefanocs 2016/07/26 06:08:31 I'm reusing an existing enum. I think it has a sim

}

bool secure_origin = content::IsOriginSecure(requesting_origin);

« no previous file with comments | « no previous file | chrome/browser/safe_browsing/permission_reporter.h » ('j') | chrome/browser/safe_browsing/permission_reporter.h » ('J')