Chromium Code Reviews Chromium Code Reviews
Issue 2178213002:
Add note page to settings. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@stylus-add-switch| Index: chrome/browser/resources/settings/device_page/device_page.html |
| diff --git a/chrome/browser/resources/settings/device_page/device_page.html b/chrome/browser/resources/settings/device_page/device_page.html |
| index a8dd3bea3fd702705ebeed29053d4abc41a88a3e..a3a189bff5dad45ee04205121db86765301c9db3 100644 |
| --- a/chrome/browser/resources/settings/device_page/device_page.html |
| +++ b/chrome/browser/resources/settings/device_page/device_page.html |
| @@ -7,6 +7,7 @@ |
| <link rel="import" href="/device_page/device_page_browser_proxy.html"> |
| <link rel="import" href="/device_page/display.html"> |
| <link rel="import" href="/device_page/keyboard.html"> |
| +<link rel="import" href="/device_page/note.html"> |
| <link rel="import" href="/device_page/pointers.html"> |
| <link rel="import" href="/icons.html"> |
| <link rel="import" href="/prefs/prefs.html"> |
| @@ -33,6 +34,14 @@ |
| <iron-icon icon="settings:keyboard"></iron-icon> |
| <div class="middle">$i18n{keyboardTitle}</div> |
| </div> |
| + <template is="dom-if" if=[[noteAllowed_]]> |
| + <div id="noteRow" class="settings-box" on-tap="onNoteTap_" |
|
stevenjb
2016/07/26 23:21:39
id not needed?
jdufault
2016/07/27 20:55:01
Done.
|
| + actionable> |
| + <iron-icon icon="settings:note"></iron-icon> |
| + <!-- TODO(jdufault): i18n --> |
| + <div class="middle">Note</div> |
|
stevenjb
2016/07/26 23:21:39
We should do i18n now, it's easy to miss something
jdufault
2016/07/27 20:55:01
Done.
|
| + </div> |
| + </template> |
| <div id="displayRow" class="settings-box" on-tap="onDisplayTap_" |
| actionable> |
| <iron-icon icon="settings:desktop-windows"></iron-icon> |
| @@ -53,6 +62,13 @@ |
| </settings-keyboard> |
| </settings-subpage> |
| </template> |
| + <template is="dom-if" name="note"> |
|
stevenjb
2016/07/26 23:21:39
if=?
jdufault
2016/07/27 20:55:01
Done. I've added it in another <template> wrapper,
|
| + <!-- TODO(jdufault): i18n --> |
| + <settings-subpage page-title="Notes"> |
| + <settings-note prefs="{{prefs}}" current-route="{{currentRoute}}"> |
| + </settings-note> |
| + </settings-subpage> |
| + </template> |
| <template is="dom-if" name="display"> |
| <settings-subpage page-title="$i18n{displayTitle}"> |
| <settings-display></settings-display> |
