Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2178193004: Convert editing/selection/5057506.html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/selection/5057506.html to use w3c test harness This patch converts "editing/selection/5057506.html" to use w3c test harness to simplify test script, and rename "double_click_after_last_cell.html" to describe what this test script does. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/9790bf534f1d6bd35445cb81a990fa83785a97c0 Cr-Commit-Position: refs/heads/master@{#408037}

Patch Set 1 : 2016-07-26T18:38:20 #

Total comments: 1

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-07-27 02:24:07 UTC) #5
Xiaocheng
lgtm with a nit. https://codereview.chromium.org/2178193004/diff/1/third_party/WebKit/LayoutTests/editing/selection/mouse/double_click_after_last_cell.html File third_party/WebKit/LayoutTests/editing/selection/mouse/double_click_after_last_cell.html (right): https://codereview.chromium.org/2178193004/diff/1/third_party/WebKit/LayoutTests/editing/selection/mouse/double_click_after_last_cell.html#newcode23 third_party/WebKit/LayoutTests/editing/selection/mouse/double_click_after_last_cell.html:23: y = span.offsetParent.offsetParent.offsetTop + span.offsetParent.offsetTop ...
4 years, 4 months ago (2016-07-27 02:43:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178193004/1
4 years, 4 months ago (2016-07-27 04:07:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 04:11:03 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 04:12:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9790bf534f1d6bd35445cb81a990fa83785a97c0
Cr-Commit-Position: refs/heads/master@{#408037}

Powered by Google App Engine
This is Rietveld 408576698