Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2459)

Unified Diff: ash/test/shelf_view_test_api.cc

Issue 2178163002: Add ink drop ripple to shelf overflow button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/test/shelf_view_test_api.cc
diff --git a/ash/test/shelf_view_test_api.cc b/ash/test/shelf_view_test_api.cc
index a14432c1f958ecc65d3c30f7f3d96a4e4cb8a0ab..c9ff178cbc0bf44d073f09ef2d7f9e70f5c7fb3a 100644
--- a/ash/test/shelf_view_test_api.cc
+++ b/ash/test/shelf_view_test_api.cc
@@ -68,8 +68,17 @@ bool ShelfViewTestAPI::IsOverflowButtonVisible() {
}
void ShelfViewTestAPI::ShowOverflowBubble() {
- if (!shelf_view_->IsShowingOverflowBubble())
- shelf_view_->ToggleOverflowBubble();
+ DCHECK(!shelf_view_->IsShowingOverflowBubble());
+ shelf_view_->ToggleOverflowBubble();
+}
+
+void ShelfViewTestAPI::HideOverflowBubble() {
+ DCHECK(shelf_view_->IsShowingOverflowBubble());
+ shelf_view_->ToggleOverflowBubble();
+}
+
+bool ShelfViewTestAPI::IsShowingOverflowBubble() const {
+ return shelf_view_->IsShowingOverflowBubble();
}
const gfx::Rect& ShelfViewTestAPI::GetBoundsByIndex(int index) {
@@ -110,6 +119,10 @@ OverflowBubble* ShelfViewTestAPI::overflow_bubble() {
return shelf_view_->overflow_bubble_.get();
}
+OverflowButton* ShelfViewTestAPI::overflow_button() const {
+ return shelf_view_->overflow_button_;
+}
+
ShelfTooltipManager* ShelfViewTestAPI::tooltip_manager() {
return &shelf_view_->tooltip_;
}

Powered by Google App Engine
This is Rietveld 408576698