Add ink drop ripple to shelf overflow button

ui/views/controls/button/custom_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/custom_button.h"
 
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
@@ skipping 166 matching lines @@
           ink_drop()->GetTargetInkDropState() ==
               views::InkDropState::ACTION_PENDING) {
         AnimateInkDrop(views::InkDropState::HIDDEN, &event);
       }
     }
   }
   return true;
 }
 
 void CustomButton::OnMouseReleased(const ui::MouseEvent& event) {
+  const bool was_pressed = state_ == STATE_PRESSED;
+
   if (state_ != STATE_DISABLED) {
     if (!HitTestPoint(event.location())) {
       SetState(STATE_NORMAL);
     } else {
       SetState(STATE_HOVERED);
       if (IsTriggerableEvent(event) && notify_action_ == NOTIFY_ON_RELEASE) {
         NotifyClick(event);
         // NOTE: We may be deleted at this point (by the listener's notification
         // handler).
         return;
       }
     }
   }
-  if (notify_action_ == NOTIFY_ON_RELEASE)
+  if (notify_action_ == NOTIFY_ON_RELEASE && was_pressed)

[bruthig, 2016/09/01 16:12:54]

Correct me if I'm wrong but you said that OnClickCanceled() can sometimes be
called when the mouse is released with no corresponding mouse press correct?  If
so, can you just add a comment here stating that.

[mohsen, 2016/09/10 03:03:23]

Not exactly. Probably, what I meant was that OnClickCanceled() can be called
even if mouse pressed did not change the button state to PRESSED (e.g. when the
button is disabled). This can be deduced from the comments above
OnClickCanceled() declaration ("Called when a button gets released without
triggering an action").

     OnClickCanceled(event);
 }
 
 void CustomButton::OnMouseCaptureLost() {
   // Starting a drag results in a MouseCaptureLost. Reset button state.
   // TODO(varkha) While in drag only reset the state with Material Design.
   // The same logic may applies everywhere so gather any feedback and update.
   bool reset_button_state =
       !InDrag() || ui::MaterialDesignController::IsModeMaterial();
   if (state_ != STATE_DISABLED && reset_button_state)
@@ skipping 258 matching lines @@
   Button::NotifyClick(event);
 }
 
 void CustomButton::OnClickCanceled(const ui::Event& event) {
   AnimateInkDrop(views::InkDropState::HIDDEN,
                  ui::LocatedEvent::FromIfValid(&event));
   Button::OnClickCanceled(event);
 }
 
 }  // namespace views