Add ink drop ripple to shelf overflow button

ui/views/controls/button/custom_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/custom_button.h"
 
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
@@ skipping 452 matching lines @@
 
 void CustomButton::NotifyClick(const ui::Event& event) {
   if (has_ink_drop_action_on_click_) {
     AnimateInkDrop(InkDropState::ACTION_TRIGGERED,
                    ui::LocatedEvent::FromIfValid(&event));
   }
   Button::NotifyClick(event);
 }
 
 void CustomButton::OnClickCanceled(const ui::Event& event) {
-  AnimateInkDrop(views::InkDropState::HIDDEN,
-                 ui::LocatedEvent::FromIfValid(&event));
+  if (ink_drop()->GetTargetInkDropState() != views::InkDropState::ACTIVATED) {

[bruthig, 2016/07/26 21:24:27]

I think I'd feel better if this were configurable on the InkDropHostView. i.e.
InkDropHostView::should_hide_ripple_on_click_cancel_.

WDYT?

[mohsen, 2016/08/17 05:31:35]

I changed the code such that OnClickCanceled() is not called at all if button is
not in the pressed state. So, this is not needed anymore.

+    AnimateInkDrop(views::InkDropState::HIDDEN,
+                   ui::LocatedEvent::FromIfValid(&event));
+  }
   Button::OnClickCanceled(event);
 }
 
 }  // namespace views