Add ink drop ripple to shelf overflow button

ui/views/animation/ink_drop_host_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/animation/ink_drop_host_view.h"
 
 #include "ui/events/event.h"
 #include "ui/events/scoped_target_handler.h"
 #include "ui/gfx/color_palette.h"
 #include "ui/gfx/geometry/size_conversions.h"
@@ skipping 40 matching lines @@
   ~InkDropGestureHandler() override {}
 
   // ui::EventHandler:
   void OnGestureEvent(ui::GestureEvent* event) override {
     InkDropState current_ink_drop_state =
         host_view_->ink_drop()->GetTargetInkDropState();
 
     InkDropState ink_drop_state = InkDropState::HIDDEN;
     switch (event->type()) {
       case ui::ET_GESTURE_TAP_DOWN:
+        if (current_ink_drop_state == InkDropState::ACTIVATED)

[bruthig, 2016/07/26 13:57:15]

Can you double check this logic still works well with the BookmarkButtons?  e.g.
1. Open a folder button
2. Tap and hold for a delay.  I expect the ripple to be visible
3. If you release the tap after a long enough delay the menu is re-shown and the
ripple transitions to ACTIVATED.

[mohsen, 2016/07/26 20:00:58]

This seems to work. The activated ripple is hidden before the tap-down reaches
here, so the early out does not happen.

+          return;
         ink_drop_state = InkDropState::ACTION_PENDING;
         // The ui::ET_GESTURE_TAP_DOWN event needs to be marked as handled so
         // that
         // subsequent events for the gesture are sent to |this|.
         event->SetHandled();
         break;
       case ui::ET_GESTURE_LONG_PRESS:
+        if (current_ink_drop_state == InkDropState::ACTIVATED)
+          return;
         ink_drop_state = InkDropState::ALTERNATE_ACTION_PENDING;
         break;
       case ui::ET_GESTURE_LONG_TAP:
         ink_drop_state = InkDropState::ALTERNATE_ACTION_TRIGGERED;
         break;
       case ui::ET_GESTURE_END:
         if (current_ink_drop_state == InkDropState::ACTIVATED)
           return;
       // Fall through to ui::ET_GESTURE_SCROLL_BEGIN case.
       case ui::ET_GESTURE_SCROLL_BEGIN:
@@ skipping 158 matching lines @@
   else
     ink_drop_.reset(new InkDropImpl(this));
 
   if (ink_drop_mode != InkDropMode::ON)
     gesture_handler_.reset();
   else if (!gesture_handler_)
     gesture_handler_.reset(new InkDropGestureHandler(this));
 }
 
 }  // namespace views