third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp - Issue 2178153004: [DevTools] Do not expose findSource{Map}URL from v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 2178153004: [DevTools] Do not expose findSource{Map}URL from v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove more String16 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

index 20f19e5afe09ee0975b806215c2770e1c33d1e42..63ac94240e7de1be7b2443e0999c31cb592437f4 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

@@ -16,7 +16,6 @@

#include "platform/v8_inspector/V8RuntimeAgentImpl.h"

#include "platform/v8_inspector/V8StackTraceImpl.h"

#include "platform/v8_inspector/V8StringUtil.h"

-#include "platform/v8_inspector/public/V8ContentSearchUtil.h"

#include "platform/v8_inspector/public/V8Debugger.h"

#include "platform/v8_inspector/public/V8DebuggerClient.h"

@@ -994,15 +993,15 @@ void V8DebuggerAgentImpl::didParseSource(std::unique_ptr<V8DebuggerScript> scrip

String16 scriptSource = toProtocolString(script->source(m_isolate));

bool isDeprecatedSourceURL = false;

if (!success)

- script->setSourceURL(V8ContentSearchUtil::findSourceURL(scriptSource, false, &isDeprecatedSourceURL));

+ script->setSourceURL(findSourceURL(scriptSource, false, &isDeprecatedSourceURL));

else if (script->hasSourceURL())

- V8ContentSearchUtil::findSourceURL(scriptSource, false, &isDeprecatedSourceURL);

+ findSourceURL(scriptSource, false, &isDeprecatedSourceURL);

bool isDeprecatedSourceMappingURL = false;

if (!success)

- script->setSourceMappingURL(V8ContentSearchUtil::findSourceMapURL(scriptSource, false, &isDeprecatedSourceMappingURL));

+ script->setSourceMappingURL(findSourceMapURL(scriptSource, false, &isDeprecatedSourceMappingURL));

else if (!script->sourceMappingURL().isEmpty())

- V8ContentSearchUtil::findSourceMapURL(scriptSource, false, &isDeprecatedSourceMappingURL);

+ findSourceMapURL(scriptSource, false, &isDeprecatedSourceMappingURL);

bool isContentScript = script->isContentScript();

bool isInternalScript = script->isInternalScript();