Pass the /safeseh option to ml.exe.

test/win/gyptest-link-safeseh.py

Index: test/win/gyptest-link-safeseh.py
diff --git a/test/win/gyptest-link-safeseh.py b/test/win/gyptest-link-safeseh.py
new file mode 100644
index 0000000000000000000000000000000000000000..0d840096327b95f8f1f1c72e28f7a558dcc88240
--- /dev/null
+++ b/test/win/gyptest-link-safeseh.py
@@ -0,0 +1,40 @@
+#!/usr/bin/env python
+
+# Copyright (c) 2014 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Make sure safeseh setting is extracted properly.
+"""
+
+import TestGyp
+
+import sys
+
+if sys.platform == 'win32':
+  test = TestGyp.TestGyp(formats=['ninja'])

[wtc, 2014/04/10 22:21:43]

If I add the 'msvs' format here, the test emits the warning message "Warning:
unrecognized setting VCLinkerTool/ImageHasSafeExceptionHandlers while converting
to MSBuild." and then fails.

[scottmg, 2014/04/10 22:57:08]

OK, I've probably led you astray then, or something needs to be added to the vs
generator. I think it's fine as is for now.

+
+  CHDIR = 'linker-flags'
+  test.run_gyp('safeseh.gyp', chdir=CHDIR)
+  test.build('safeseh.gyp', test.ALL, chdir=CHDIR)
+
+  def HasSafeExceptionHandlers(exe):
+    full_path = test.built_file_path(exe, chdir=CHDIR)
+    output = test.run_dumpbin('/LOADCONFIG', full_path)

[wtc, 2014/04/10 22:21:43]

The dumpbin flag is /LOADCONFIG:

$ dumpbin -loadconfig foo.exe
Microsoft (R) COFF/PE Dumper Version 10.00.40219.01
Copyright (C) Microsoft Corporation.  All rights reserved.


Dump of file foo.exe

File Type: EXECUTABLE IMAGE

  Section contains the following load config:

            00000048 size
            ...
            004099F0 Safe Exception Handler Table
                   3 Safe Exception Handler Count

    Safe Exception Handler Table

          Address
          --------
          00402AA0
          00405580
          004075F0

+    return '    Safe Exception Handler Table' in output

[wtc, 2014/04/10 22:21:43]

Should I insist on the leading spaces? I am imitating gyptest-link-aslr.py, but
am worried that a future change in dumpbin output formatting may break this
test.

+
+  # From MSDN: http://msdn.microsoft.com/en-us/library/9a89h429.aspx
+  #   If /SAFESEH is not specified, the linker will produce an image with a
+  #   table of safe exceptions handlers if all modules are compatible with
+  #   the safe exception handling feature. If any modules were not
+  #   compatible with safe exception handling feature, the resulting image
+  #   will not contain a table of safe exception handlers.
+  if HasSafeExceptionHandlers('test_safeseh_default.exe'):
+    test.fail_test()
+  if HasSafeExceptionHandlers('test_safeseh_no.exe'):
+    test.fail_test()
+  if not HasSafeExceptionHandlers('test_safeseh_yes.exe'):
+    test.fail_test()
+
+  test.pass_test()