Remove the kEasyOffStoreInstall switch

Remove the kEasyOffStoreInstall switch

BUG=357750
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262265

[Devlin, 2014-03-31 18:44:06]

jyasskin: extensions/*
sky: chrome/test/ui/ui_test.cc

Please take a look when you can :)

[Jeffrey Yasskin, 2014-03-31 19:53:46]

Could you elaborate in the bug? I'd guess that there are people using this
switch intentionally, and we'll want them to find that bug and see a good reason
there, rather than just thinking that we haven't considered their use case.

[Devlin, 2014-03-31 20:16:18]

On 2014/03/31 19:53:46, Jeffrey Yasskin wrote:
> Could you elaborate in the bug? I'd guess that there are people using this
> switch intentionally, and we'll want them to find that bug and see a good
reason
> there, rather than just thinking that we haven't considered their use case.

Good point.  Figured most people would just refer to the master bug, but it's
good to be more clear on things like this.  How this look?  crbug.com/357750

[Jeffrey Yasskin, 2014-03-31 20:18:02]

lgtm

[sky, 2014-03-31 20:58:42]

ui_test LGTM

[Devlin, 2014-03-31 21:01:44]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-03-31 21:01:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/217813002/1

[commit-bot: I haz the power, 2014-04-01 22:02:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/217813002/1

[commit-bot: I haz the power, 2014-04-01 22:54:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/217813002/1

[commit-bot: I haz the power, 2014-04-02 02:07:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/217813002/1

[commit-bot: I haz the power, 2014-04-03 08:32:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 08:32:29]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[Devlin, 2014-04-03 13:46:15]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-04-03 13:47:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/217813002/1

[commit-bot: I haz the power, 2014-04-03 20:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 20:23:38]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[Devlin, 2014-04-04 17:08:30]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-04-04 17:08:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/217813002/1

[commit-bot: I haz the power, 2014-04-04 21:21:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/217813002/1

[commit-bot: I haz the power, 2014-04-04 21:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-04 21:22:02]

Failed to apply patch for chrome/test/ui/ui_test.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         chrome/test/ui
  Created missing directory chrome/test/ui.
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: chrome/test/ui/ui_test.cc
  |diff --git a/chrome/test/ui/ui_test.cc b/chrome/test/ui/ui_test.cc
  |index
c244eead041e21deec3eaeee4b6268ad59a4ad68..47dcb17875f4ddf63e56bcf8e1c2ca76a1bd3018
100644
  |--- a/chrome/test/ui/ui_test.cc
  |+++ b/chrome/test/ui/ui_test.cc
  --------------------------
  No file to patch.  Skipping patch.
  2 out of 2 hunks ignored

Patch:       chrome/test/ui/ui_test.cc
Index: chrome/test/ui/ui_test.cc
diff --git a/chrome/test/ui/ui_test.cc b/chrome/test/ui/ui_test.cc
index
c244eead041e21deec3eaeee4b6268ad59a4ad68..47dcb17875f4ddf63e56bcf8e1c2ca76a1bd3018
100644
--- a/chrome/test/ui/ui_test.cc
+++ b/chrome/test/ui/ui_test.cc
@@ -50,7 +50,7 @@
 #include "chrome/test/base/test_launcher_utils.h"
 #include "chrome/test/base/test_switches.h"
 #include "chrome/test/base/testing_profile.h"
-#include "extensions/common/switches.h"
+#include "extensions/common/feature_switch.h"
 #include "net/base/net_util.h"
 #include "ui/gl/gl_implementation.h"
 #include "url/gurl.h"
@@ -189,8 +189,8 @@ void UITestBase::SetLaunchSwitches() {
   if (stats_collection_controller_enabled_)
     launch_arguments_.AppendSwitch(switches::kStatsCollectionController);
   // Allow off-store extension installs.
-  launch_arguments_.AppendSwitchASCII(
-      extensions::switches::kEasyOffStoreExtensionInstall, "1");
+  extensions::FeatureSwitch::easy_off_store_install()->SetOverrideValue(
+      extensions::FeatureSwitch::OVERRIDE_ENABLED);
   if (!homepage_.empty()) {
     // Pass |homepage_| both as an arg (so that it opens on startup) and to the
     // homepage switch (so that the homepage is set).

[Devlin, 2014-04-07 20:39:30]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-04-07 20:43:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/217813002/...

[commit-bot: I haz the power, 2014-04-08 00:16:10]

Change committed as 262265