Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2178123003: Issue 26860. Report CompileTimeErrorCode.FIELD_INITIALIZER_OUTSIDE_CONSTRUCTOR for parameters of fu… (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 26860. Report CompileTimeErrorCode.FIELD_INITIALIZER_OUTSIDE_CONSTRUCTOR for parameters of function typed constructor parameters. R=pquitslund@google.com, brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/26860 Committed: https://github.com/dart-lang/sdk/commit/f8c32c5ea1a7f7ce0786af3c30a8f70d01b361f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +24 lines, -19 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 4 months ago (2016-07-25 21:16:24 UTC) #1
pquitslund
lgtm
4 years, 4 months ago (2016-07-25 21:39:31 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as f8c32c5ea1a7f7ce0786af3c30a8f70d01b361f0 (presubmit successful).
4 years, 4 months ago (2016-07-25 21:56:53 UTC) #4
Brian Wilkerson
4 years, 4 months ago (2016-07-27 14:12:28 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698