components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java - Issue 2178053002: Change RequestFinishedListener to provide executor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

Issue 2178053002: Change RequestFinishedListener to provide executor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/api/src/org/chromium/net/UrlRequest.java ('k') | components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

index fd13de1b7f0d002fea46abca29b1e4ae8cb02e72..da4cc00a797b36addc322d91477475ece9566148 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

@@ -492,9 +492,8 @@ public final class CronetUrlRequest implements UrlRequest {

////////////////////////////////////////////////

/**

- * Called before following redirects. The redirect will automatically be

- * followed, unless the request is paused or canceled during this

- * callback. If the redirect response has a body, it will be ignored.

+ * Called before following redirects. The redirect will only be followed if

+ * {@link #followRedirect()} is called. If the redirect response has a body, it will be ignored.

* This will only be called between start and onResponseStarted.

* @param newLocation Location where request is redirected.