Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 2178053002: Change RequestFinishedListener to provide executor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: formatting Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
index a5752d8ec6e1aa768cb8163487f2e15ab61b2588..5208651ce913a7e7d9ee5b133ecbaadf081c2a1b 100644
--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
@@ -838,14 +838,14 @@ public abstract class CronetEngine {
* @param priority priority of the request which should be one of the
* {@link UrlRequest.Builder#REQUEST_PRIORITY_IDLE REQUEST_PRIORITY_*}
* values.
- * @param requestAnnotations Objects to pass on to {@link CronetEngine.RequestFinishedListener}.
+ * @param requestAnnotations Objects to pass on to {@link RequestFinishedListener}.
* @param disableCache disables cache for the request.
* If context is not set up to use cache this param has no effect.
* @param disableConnectionMigration disables connection migration for this
* request if it is enabled for the session.
* @return new request.
* @deprecated Use {@link UrlRequest.Builder#build}.
- * @hide as it references hidden CronetEngine.RequestFinishedListener
+ * @hide as it references hidden RequestFinishedListener
*/
@Deprecated
protected abstract UrlRequest createRequest(String url, UrlRequest.Callback callback,
@@ -1268,19 +1268,4 @@ public abstract class CronetEngine {
return mReceivedBytesCount;
}
}
-
- /**
- * Interface to listen for finished requests that were created via this CronetEngine instance.
- *
- * TODO(tbansal): http://crbug.com/618034 Remove this API, and replace it with a listener
- * whose executor is bound to the lifetime of the listener.
- * @hide as it's a prototype.
- */
- public interface RequestFinishedListener {
- /**
- * Invoked with request info.
- * @param requestInfo {@link UrlRequestInfo} for finished request.
- */
- void onRequestFinished(UrlRequestInfo requestInfo);
- }
}
« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | components/cronet/android/api/src/org/chromium/net/RequestFinishedListener.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698