Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2178033003: Fix ipc_fuzzer linking in CrOS ASAN builds. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ipc_fuzzer linking in CrOS ASAN builds. R=mbarbella@chromium.org, inferno@chromium.org BUG=630905 Committed: https://crrev.com/0fbf95f476ce059f7a7a1e5c8ae00e5557c45f9c Cr-Commit-Position: refs/heads/master@{#407610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/ipc_fuzzer/fuzzer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
Please take a look at the bug for all of the context, particularly comment #7. ...
4 years, 4 months ago (2016-07-25 20:19:15 UTC) #1
Martin Barbella
lgtm
4 years, 4 months ago (2016-07-25 20:34:52 UTC) #2
inferno
Alex - any idea why we need linker flags at all here ?
4 years, 4 months ago (2016-07-25 20:41:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178033003/1
4 years, 4 months ago (2016-07-25 20:58:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-25 22:03:26 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 22:06:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fbf95f476ce059f7a7a1e5c8ae00e5557c45f9c
Cr-Commit-Position: refs/heads/master@{#407610}

Powered by Google App Engine
This is Rietveld 408576698