Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2177983002: Adds AcceleratorManagerDelegate (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds AcceleratorManagerDelegate Which is notified as accelerators are added/removed. BUG=612331 TEST=none R=ben@chromium.org Committed: https://crrev.com/0420380e5d69fbc523b00cda0b94da515bc693f9 Cr-Commit-Position: refs/heads/master@{#407538}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -34 lines) Patch
M ui/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/accelerators/accelerator_manager.h View 1 3 chunks +15 lines, -5 lines 0 comments Download
M ui/base/accelerators/accelerator_manager.cc View 1 5 chunks +49 lines, -28 lines 0 comments Download
A ui/base/accelerators/accelerator_manager_delegate.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
M ui/base/accelerators/accelerator_manager_unittest.cc View 1 5 chunks +85 lines, -1 line 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sky
4 years, 5 months ago (2016-07-25 16:17:33 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 5 months ago (2016-07-25 18:48:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177983002/20001
4 years, 5 months ago (2016-07-25 19:04:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-25 19:08:29 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 19:14:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0420380e5d69fbc523b00cda0b94da515bc693f9
Cr-Commit-Position: refs/heads/master@{#407538}

Powered by Google App Engine
This is Rietveld 408576698