Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2177963002: Reland of grit: Automatically replace ... with … (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 4 months ago
Reviewers:
flackr, asanka, Mark P
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, kalyank, oshima+watch_chromium.org, sadrul, sdefresne+watch_chromium.org, Alexei Svitkine (slow), Daniel Erat, jochen (gone - plz use gerrit), jungshik at Google, msw, oshima, sdefresne, sky, kerz_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of grit: Automatically replace ... with … Previous change: https://codereview.chromium.org/2176663003/ Reason for Reland: I've added rebaselines to TestExpectations, following: https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations#TOC-How-to-rebaseline TBR=flackr@chromium.org,asanka@chromium.org,mpearson@chromium.org BUG=621772 Committed: https://crrev.com/706d93d0da0e71822978da65221d146400433f7f Cr-Commit-Position: refs/heads/master@{#407548}

Patch Set 1 #

Patch Set 2 : rebaseline #

Total comments: 1

Patch Set 3 : rebaseline #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -14 lines) Patch
M chrome/browser/download/download_item_model_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +6 lines, -0 lines 2 comments Download
M tools/grit/grit/node/message.py View 1 4 chunks +14 lines, -3 lines 0 comments Download
M tools/grit/grit/node/message_unittest.py View 1 2 chunks +19 lines, -3 lines 0 comments Download
M tools/grit/grit/tool/build.py View 1 5 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
agrieve
Created Reland of grit: Automatically replace ... with …
4 years, 5 months ago (2016-07-25 15:54:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177963002/100001
4 years, 5 months ago (2016-07-25 18:15:20 UTC) #4
Mark P
https://codereview.chromium.org/2177963002/diff/100001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2177963002/diff/100001/third_party/WebKit/LayoutTests/TestExpectations#newcode487 third_party/WebKit/LayoutTests/TestExpectations:487: crbug.com/621772 fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html [ NeedsRebaseline ] You have omitted some ...
4 years, 5 months ago (2016-07-25 18:20:05 UTC) #6
agrieve
On 2016/07/25 18:20:05, Mark P (no metrics til 7-26) wrote: > https://codereview.chromium.org/2177963002/diff/100001/third_party/WebKit/LayoutTests/TestExpectations > File third_party/WebKit/LayoutTests/TestExpectations ...
4 years, 5 months ago (2016-07-25 18:34:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177963002/120001
4 years, 5 months ago (2016-07-25 18:36:07 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:120001)
4 years, 4 months ago (2016-07-25 19:42:17 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/706d93d0da0e71822978da65221d146400433f7f Cr-Commit-Position: refs/heads/master@{#407548}
4 years, 4 months ago (2016-07-25 19:45:59 UTC) #13
Mark P
https://codereview.chromium.org/2177963002/diff/120001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2177963002/diff/120001/third_party/WebKit/LayoutTests/TestExpectations#newcode490 third_party/WebKit/LayoutTests/TestExpectations:490: crbug.com/621772 fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html [ NeedsRebaseline ] Apparently we need one ...
4 years, 4 months ago (2016-07-25 23:46:34 UTC) #14
agrieve
https://codereview.chromium.org/2177963002/diff/120001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2177963002/diff/120001/third_party/WebKit/LayoutTests/TestExpectations#newcode490 third_party/WebKit/LayoutTests/TestExpectations:490: crbug.com/621772 fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html [ NeedsRebaseline ] On 2016/07/25 23:46:34, Mark ...
4 years, 4 months ago (2016-07-26 00:22:56 UTC) #15
kerz_google
On 2016/07/26 00:22:56, agrieve wrote: > https://codereview.chromium.org/2177963002/diff/120001/third_party/WebKit/LayoutTests/TestExpectations > File third_party/WebKit/LayoutTests/TestExpectations (right): > > https://codereview.chromium.org/2177963002/diff/120001/third_party/WebKit/LayoutTests/TestExpectations#newcode490 > ...
4 years, 4 months ago (2016-08-05 17:07:36 UTC) #16
agrieve
4 years, 4 months ago (2016-08-05 17:59:40 UTC) #18
Message was sent while issue was closed. 
On 2016/08/05 17:07:36, kerz_google wrote:
> On 2016/07/26 00:22:56, agrieve wrote:
> >
>
https://codereview.chromium.org/2177963002/diff/120001/third_party/WebKit/Lay...
> > File third_party/WebKit/LayoutTests/TestExpectations (right):
> > 
> >
>
https://codereview.chromium.org/2177963002/diff/120001/third_party/WebKit/Lay...
> > third_party/WebKit/LayoutTests/TestExpectations:490: crbug.com/621772
> > fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html [
> > NeedsRebaseline ]
> > On 2016/07/25 23:46:34, Mark P (no metrics til 7-26) wrote:
> > > Apparently we need one more test here:
> > > fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html
> > > 
> > > My git checkout got hosed sometime today.  Can you please add it?
> > 
> > On it.
> 
> Is this going to cause re-translation for all of the instances of ...?

Unless I've messed it up (always possible), it shouldn't trigger re-translation.

Powered by Google App Engine
This is Rietveld 408576698