Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2177943002: [Lightweight FRE] Do not show Lightweight FRE if it is disabled (Closed)

Created:
4 years, 5 months ago by gogerald1
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not show Lightweight FRE if it is disabled BUG=630991 Committed: https://crrev.com/53fe02c66f753e2863267ef1d40dff81d1746773 Cr-Commit-Position: refs/heads/master@{#408387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java View 4 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
gogerald1
Hi, PTAL,
4 years, 5 months ago (2016-07-25 15:09:58 UTC) #6
Bernhard Bauer
Sorry, overlooked this. LGTM!
4 years, 4 months ago (2016-07-28 09:15:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177943002/1
4 years, 4 months ago (2016-07-28 13:41:08 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 14:09:28 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 14:11:22 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53fe02c66f753e2863267ef1d40dff81d1746773
Cr-Commit-Position: refs/heads/master@{#408387}

Powered by Google App Engine
This is Rietveld 408576698