Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2177933004:
Remove thread TaskRunner hack from ChannelAssociatedGroupController (Closed)
|
Created:
4 years, 4 months ago by Ken Rockot(use gerrit already) Modified:
4 years, 4 months ago Reviewers:
yzshen1 CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-browser-thread-task-runner Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove thread TaskRunner hack from ChannelAssociatedGroupController
With BrowserThreadTaskRunner fixed it is no longer necessary for
ChannelAssociatedGroupController to cache the thread's
ThreadTaskRunnerHandle during Bind. It can instead rely on its
IPC TaskRunner correctly reporting RunsTasksOnCurrentThread even
during shutdown.
BUG=631093
R=yzshen@chromium.org
Committed: https://crrev.com/7604e7b739ece0f6c3d5314cfe6b3be8431c3f7b
Cr-Commit-Position: refs/heads/master@{#408427}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #
Depends on Patchset: Messages
Total messages: 25 (19 generated)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM Yay!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rockot@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org Link to the patchset: https://codereview.chromium.org/2177933004/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by rockot@chromium.org
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by rockot@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org Link to the patchset: https://codereview.chromium.org/2177933004/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove thread TaskRunner hack from ChannelAssociatedGroupController With BrowserThreadTaskRunner fixed it is no longer necessary for ChannelAssociatedGroupController to cache the thread's ThreadTaskRunnerHandle during Bind. It can instead rely on its IPC TaskRunner correctly reporting RunsTasksOnCurrentThread even during shutdown. BUG=631039 R=yzshen@chromium.org ========== to ========== Remove thread TaskRunner hack from ChannelAssociatedGroupController With BrowserThreadTaskRunner fixed it is no longer necessary for ChannelAssociatedGroupController to cache the thread's ThreadTaskRunnerHandle during Bind. It can instead rely on its IPC TaskRunner correctly reporting RunsTasksOnCurrentThread even during shutdown. BUG=631039 R=yzshen@chromium.org Committed: https://crrev.com/7604e7b739ece0f6c3d5314cfe6b3be8431c3f7b Cr-Commit-Position: refs/heads/master@{#408427} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7604e7b739ece0f6c3d5314cfe6b3be8431c3f7b Cr-Commit-Position: refs/heads/master@{#408427}
Message was sent while issue was closed.
Description was changed from ========== Remove thread TaskRunner hack from ChannelAssociatedGroupController With BrowserThreadTaskRunner fixed it is no longer necessary for ChannelAssociatedGroupController to cache the thread's ThreadTaskRunnerHandle during Bind. It can instead rely on its IPC TaskRunner correctly reporting RunsTasksOnCurrentThread even during shutdown. BUG=631039 R=yzshen@chromium.org Committed: https://crrev.com/7604e7b739ece0f6c3d5314cfe6b3be8431c3f7b Cr-Commit-Position: refs/heads/master@{#408427} ========== to ========== Remove thread TaskRunner hack from ChannelAssociatedGroupController With BrowserThreadTaskRunner fixed it is no longer necessary for ChannelAssociatedGroupController to cache the thread's ThreadTaskRunnerHandle during Bind. It can instead rely on its IPC TaskRunner correctly reporting RunsTasksOnCurrentThread even during shutdown. BUG=631093 R=yzshen@chromium.org Committed: https://crrev.com/7604e7b739ece0f6c3d5314cfe6b3be8431c3f7b Cr-Commit-Position: refs/heads/master@{#408427} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
