Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2177903002: [test] copy revoked proxy tests for array-concat to new files (Closed)

Created:
4 years, 5 months ago by caitp
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] copy revoked proxy tests for array-concat to new files The tests array-concat-revoked-proxy-*.js are copied out from array-concat.js, in order to verify that they work correctly with a valid ArrayProtector cell. These tests pass with https://crrev.com/122a9b7af02606dae558336082ab139a87eba39d applied, but fail without it. BUG=v8:5134 R=neis@chromium.org, cbruni@chromium.org, littledan@chromium.org Committed: https://crrev.com/917f0093fbe7fde106be03306cddefe677c1b3f4 Cr-Commit-Position: refs/heads/master@{#38026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
A test/mjsunit/es6/array-concat-revoked-proxy-1.js View 1 chunk +19 lines, -0 lines 0 comments Download
A test/mjsunit/es6/array-concat-revoked-proxy-2.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caitp
PTAL --- Should have been included as part of https://codereview.chromium.org/2131383002/, but forgot =] It's fine ...
4 years, 5 months ago (2016-07-25 14:30:25 UTC) #1
Camillo Bruni
LGTM no problemo, just land them separately.
4 years, 5 months ago (2016-07-25 14:56:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177903002/1
4 years, 5 months ago (2016-07-25 15:00:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 15:21:02 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 15:26:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/917f0093fbe7fde106be03306cddefe677c1b3f4
Cr-Commit-Position: refs/heads/master@{#38026}

Powered by Google App Engine
This is Rietveld 408576698