Source/core/animation/css/CSSAnimations.cpp - Issue 21779003: Web Animations CSS: Snapshot missing start/end Keyframes and remove duplicates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/css/CSSAnimations.cpp

Issue 21779003: Web Animations CSS: Snapshot missing start/end Keyframes and remove duplicates (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address review comments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/KeyframeAnimationEffect.cpp ('k') | Source/core/css/resolver/StyleResolver.cpp » ('j') | Source/core/css/resolver/StyleResolver.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/css/CSSAnimations.cpp

diff --git a/Source/core/animation/css/CSSAnimations.cpp b/Source/core/animation/css/CSSAnimations.cpp

index 281fea9593df8aa436fe62b624b4f0408382af41..e67ad68dc93c192c9bfbd8bc6c67e0bc011af995 100644

--- a/Source/core/animation/css/CSSAnimations.cpp

+++ b/Source/core/animation/css/CSSAnimations.cpp

@@ -182,6 +182,7 @@ void CSSAnimations::update(Element* element, const RenderStyle* style)

if (!keyframes.isEmpty()) {

Timing timing;

timingFromAnimationData(animationData, timing);

+ // FIXME: Keyframes are already normalized, perhaps there should be a flag on KeyframeAnimationEffect to skip normalization.

m_animations.set(animationName.impl(), element->document()->timeline()->play(

Animation::create(element, KeyframeAnimationEffect::create(keyframes), timing).get()).get());

}