Don't disable packaged / hosted Apps on profile_reset

Don't disable packaged / hosted Apps on profile_reset

BUG=267004

[vasilii, 2013-08-02 09:32:04]

ProfileResetterTest.ResetExtensionsByDisabling is broken.

https://codereview.chromium.org/21779002/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/21779002/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.cc:999: if
(!(*extension)->manifest() ||
I don't think it's possible.

https://codereview.chromium.org/21779002/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.cc:1000: type_filter.end() ==
type_filter.find((*extension)->manifest()->type()))
(*extension)->GetType()?

https://codereview.chromium.org/21779002/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.h (right):

https://codereview.chromium.org/21779002/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.h:358: const
std::set<extensions::Manifest::Type> type_filter,
const Reference. Do we really need std::set for 5 integers?

[battre, 2013-08-02 10:36:02]

upload again because git cl try fails to execute

[battre, 2013-08-02 10:36:21]

https://codereview.chromium.org/21779002/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/21779002/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.cc:999: if
(!(*extension)->manifest() ||
On 2013/08/02 09:32:04, vasilii wrote:
> I don't think it's possible.

Me neither, but I don't want to merge a crasher into the beta branch. However,
the ->GetType() method gives me enough confidence. --> Done.

https://codereview.chromium.org/21779002/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.cc:1000: type_filter.end() ==
type_filter.find((*extension)->manifest()->type()))
On 2013/08/02 09:32:04, vasilii wrote:
> (*extension)->GetType()?

Done.

https://codereview.chromium.org/21779002/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.h (right):

https://codereview.chromium.org/21779002/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.h:358: const
std::set<extensions::Manifest::Type> type_filter,
On 2013/08/02 09:32:04, vasilii wrote:
> const Reference. 

Done.

> Do we really need std::set for 5 integers?

I think it makes sense from a semantic perspective.

[vasilii, 2013-08-02 10:52:06]

https://codereview.chromium.org/21779002/diff/20002/chrome/browser/profile_re...
File chrome/browser/profile_resetter/profile_resetter_unittest.cc (right):

https://codereview.chromium.org/21779002/diff/20002/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter_unittest.cc:547:
ResetAndWait(ProfileResetter::EXTENSIONS);
Blank line after.

https://codereview.chromium.org/21779002/diff/20002/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter_unittest.cc:591:
extensions::Manifest::TYPE_EXTENSION);
No. Here it's important to install app.

[battre, 2013-08-02 11:54:12]

https://codereview.chromium.org/21779002/diff/20002/chrome/browser/profile_re...
File chrome/browser/profile_resetter/profile_resetter_unittest.cc (right):

https://codereview.chromium.org/21779002/diff/20002/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter_unittest.cc:547:
ResetAndWait(ProfileResetter::EXTENSIONS);
On 2013/08/02 10:52:06, vasilii wrote:
> Blank line after.

Done.

https://codereview.chromium.org/21779002/diff/20002/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter_unittest.cc:591:
extensions::Manifest::TYPE_EXTENSION);
On 2013/08/02 10:52:06, vasilii wrote:
> No. Here it's important to install app.

Done.

[vasilii, 2013-08-02 11:58:18]

lgtm

[asargent_no_longer_on_chrome, 2013-08-02 20:02:42]

lgtm

https://codereview.chromium.org/21779002/diff/40001/chrome/browser/extensions...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/21779002/diff/40001/chrome/browser/extensions...
chrome/browser/extensions/extension_service.cc:999: if (type_filter.end() ==
type_filter.find((*extension)->GetType()))
style nit: I personally would prefer to put the find call on the left hand side
of the == operator. This is not a hard and fast rule in the style guide so feel
free to keep it your way if you really prefer it.