Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2177863004: [Android] Reland Galaxy s5 perf bots to run using platform mode. (Closed)

Created:
4 years, 5 months ago by rnephew (Reviews Here)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Reland Galaxy s5 perf bots to run using platform mode. BUG=615157, 630627, 630640 Committed: https://chromium.googlesource.com/chromium/tools/build/+/772e098a3f629dfeadab58212623a07e54ee902a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M scripts/slave/recipes/android/perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rnephew (Reviews Here)
Need: https://codereview.chromium.org/2182563002/ https://codereview.chromium.org/2175313003/ to land before landing this.
4 years, 5 months ago (2016-07-25 20:23:10 UTC) #2
ghost stip (do not use)
rs-lgtm
4 years, 5 months ago (2016-07-25 21:45:56 UTC) #3
jbudorick
lgtm
4 years, 5 months ago (2016-07-25 21:48:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177863004/1
4 years, 5 months ago (2016-07-25 22:00:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/772e098a3f629dfeadab58212623a07e54ee902a
4 years, 5 months ago (2016-07-25 22:04:42 UTC) #8
jbudorick
4 years, 4 months ago (2016-07-26 13:43:57 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2187483002/ by jbudorick@chromium.org.

The reason for reverting is: the sharded perf tests step fails when one or more
devices are blacklisted..

Powered by Google App Engine
This is Rietveld 408576698