Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2177863002: Fix failure in mjsunit/wasm/embenchen/box2d on 32-bit architectures that do not support unaligned a… (Closed)

Created:
4 years, 5 months ago by ivica.bogosavljevic
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix failure in mjsunit/wasm/embenchen/box2d on 32-bit architectures that do not support unaligned access. This test fails because WasmGraphBuilder::BuildCFuncInstruction allocates space for doubles using StackSlot turbofan operator, but this space is not guaranteed to be 8 bytes aligned if SP itself is not 8 bytes aligned (which is the case on 32-bit architectures). BUG=mjsunit/wasm/embenchen/box2d Committed: https://crrev.com/d6386efa1baabc3f82182e19b46bb28ad815043e Cr-Commit-Position: refs/heads/master@{#38039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/wasm/wasm-external-refs.cc View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
ivica.bogosavljevic
PTAL
4 years, 5 months ago (2016-07-25 11:17:23 UTC) #2
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-25 17:51:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177863002/1
4 years, 4 months ago (2016-07-26 06:55:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20192)
4 years, 4 months ago (2016-07-26 06:57:54 UTC) #7
ivica.bogosavljevic
I need a LGTM from the file owner
4 years, 4 months ago (2016-07-26 07:47:35 UTC) #9
titzer
lgtm
4 years, 4 months ago (2016-07-26 08:13:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177863002/1
4 years, 4 months ago (2016-07-26 08:47:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177863002/1
4 years, 4 months ago (2016-07-26 08:48:05 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 08:49:11 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 08:49:41 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6386efa1baabc3f82182e19b46bb28ad815043e
Cr-Commit-Position: refs/heads/master@{#38039}

Powered by Google App Engine
This is Rietveld 408576698