Avoid unnecessary copies in ImageDecoder.

chrome/browser/chromeos/arc/arc_wallpaper_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/arc_wallpaper_handler.h"
 
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h"
 #include "components/signin/core/account_id/account_id.h"
 #include "components/user_manager/user_manager.h"
 #include "components/wallpaper/wallpaper_files_id.h"
 #include "components/wallpaper/wallpaper_layout.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 41 matching lines @@
 
 ArcWallpaperHandler::ArcWallpaperHandler() = default;
 
 ArcWallpaperHandler::~ArcWallpaperHandler() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   // Make sure the callback is never called after destruction. It is safe to
   // call Cancel() even when there is no in-flight request.
   ImageDecoder::Cancel(this);
 }
 
-void ArcWallpaperHandler::SetWallpaper(const std::vector<uint8_t>& jpeg_data) {
+void ArcWallpaperHandler::SetWallpaper(std::vector<uint8_t> jpeg_data) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   // If there is an in-flight request, cancel it. It is safe to call Cancel()
   // even when there is no in-flight request.
   ImageDecoder::Cancel(this);
-  // TODO(nya): Improve ImageDecoder to minimize copy.
-  std::string jpeg_data_as_string(
-      reinterpret_cast<const char*>(jpeg_data.data()), jpeg_data.size());
-  ImageDecoder::StartWithOptions(this, jpeg_data_as_string,
+  ImageDecoder::StartWithOptions(this, std::move(jpeg_data),
                                  ImageDecoder::ROBUST_JPEG_CODEC, true);
 }
 
 void ArcWallpaperHandler::OnImageDecoded(const SkBitmap& bitmap) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   SetBitmapAsWallpaper(bitmap);
 }
 
 void ArcWallpaperHandler::OnDecodeImageFailed() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   LOG(ERROR) << "Failed to decode wallpaper image.";
 }
 
 }  // namespace arc