Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2177793003: Convert video-seek* and video-served* http tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-seek* and video-served* http tests to testharness.js Cleaning up video-seek* and video-served* http tests to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/3ac0b77ee793abf746601e69d2e0c843cf934ab9 Cr-Commit-Position: refs/heads/master@{#407501}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 10 (5 generated)
Srirama
PTAL https://codereview.chromium.org/2177793003/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-seek-to-duration.html File third_party/WebKit/LayoutTests/http/tests/media/video-seek-to-duration.html (right): https://codereview.chromium.org/2177793003/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-seek-to-duration.html#newcode32 third_party/WebKit/LayoutTests/http/tests/media/video-seek-to-duration.html:32: return watcher.wait_for("timeupdate"); Added this extra "timeupdate" event so ...
4 years, 5 months ago (2016-07-25 11:05:06 UTC) #3
fs
lgtm https://codereview.chromium.org/2177793003/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-seek-to-duration.html File third_party/WebKit/LayoutTests/http/tests/media/video-seek-to-duration.html (right): https://codereview.chromium.org/2177793003/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-seek-to-duration.html#newcode32 third_party/WebKit/LayoutTests/http/tests/media/video-seek-to-duration.html:32: return watcher.wait_for("timeupdate"); On 2016/07/25 at 11:05:06, Srirama wrote: ...
4 years, 5 months ago (2016-07-25 15:17:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177793003/1
4 years, 5 months ago (2016-07-25 16:25:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 17:25:57 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 17:27:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ac0b77ee793abf746601e69d2e0c843cf934ab9
Cr-Commit-Position: refs/heads/master@{#407501}

Powered by Google App Engine
This is Rietveld 408576698