Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2177783003: [Editing][DOM][CodeHealth] Move Node::*editable* functions to core/editing (Closed)

Created:
4 years, 5 months ago by yoichio
Modified:
4 years, 4 months ago
Reviewers:
tkent, yosin_UTC9
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, krit, dtapuska+blinkwatch_chromium.org, dtseng+watch_chromium.org, eae+blinkwatch, f(malita), fs, groby+blinkspell_chromium.org, gyuyoung2, haraken, jchaffraix+rendering, je_julie, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, nektar+watch_chromium.org, nektarios, nzolghadr+blinkwatch_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, sof, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][DOM][CodeHealth] Move Node::*editable* functions to core/editing Move Node::*editable* functions to core/editing/EditingUtilities TEST=No change in behavior Committed: https://crrev.com/d943b19579dbce9281a8f12dca18e6deed8d8c8a Cr-Commit-Position: refs/heads/master@{#407712}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -134 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +0 lines, -123 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 chunk +7 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +108 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveNodeCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveNodePreservingChildrenCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/WrapContentsInDummySpanCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBodyElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutButton.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextFragment.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/TouchAdjustment.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
yoichio
4 years, 5 months ago (2016-07-26 02:00:27 UTC) #8
tkent
lgtm
4 years, 5 months ago (2016-07-26 02:05:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177783003/1
4 years, 5 months ago (2016-07-26 05:04:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 05:08:34 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d943b19579dbce9281a8f12dca18e6deed8d8c8a Cr-Commit-Position: refs/heads/master@{#407712}
4 years, 5 months ago (2016-07-26 05:10:00 UTC) #15
tkent
https://codereview.chromium.org/2177783003/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.h File third_party/WebKit/Source/core/editing/EditingUtilities.h (right): https://codereview.chromium.org/2177783003/diff/1/third_party/WebKit/Source/core/editing/EditingUtilities.h#newcode75 third_party/WebKit/Source/core/editing/EditingUtilities.h:75: CORE_EXPORT bool isContentEditable(const Node&); Can you clarify differences between ...
4 years, 4 months ago (2016-07-27 06:26:41 UTC) #16
yoichio
4 years, 4 months ago (2016-07-27 07:35:26 UTC) #17
Message was sent while issue was closed.
On 2016/07/27 06:26:41, tkent wrote:
>
https://codereview.chromium.org/2177783003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/EditingUtilities.h (right):
> 
>
https://codereview.chromium.org/2177783003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/EditingUtilities.h:75: CORE_EXPORT bool
> isContentEditable(const Node&);
> Can you clarify differences between
>  - isContentEditable and hasEditableStyle
>  - isContentRichlyEditable and layoutObjectIsRichlyEditable
>  - rootEditableElement and highestEditableRoot
> ?

I have found some function does logically same in
 these refactoring.
I will 'shrink' them:)

Powered by Google App Engine
This is Rietveld 408576698