Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3270)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

Issue 2177743002: Migrate page_load_metrics out of components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: migrate page_load_metrics_messages to common message generator Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
similarity index 97%
rename from components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
rename to chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
index 3c773cb94cf08942ded81dd8f04a8567d1b827a9..7a9383e415b3ac539e902283ed1f1bdd2ba553c3 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "components/page_load_metrics/browser/metrics_web_contents_observer.h"
+#include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
#include <memory>
#include <vector>
@@ -12,8 +12,9 @@
#include "base/process/kill.h"
#include "base/test/histogram_tester.h"
#include "base/time/time.h"
-#include "components/page_load_metrics/browser/page_load_metrics_observer.h"
-#include "components/page_load_metrics/common/page_load_metrics_messages.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "chrome/common/page_load_metrics/page_load_metrics_messages.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/test/test_renderer_host.h"
@@ -103,13 +104,12 @@ class TestPageLoadMetricsEmbedderInterface
} // namespace
-class MetricsWebContentsObserverTest
- : public content::RenderViewHostTestHarness {
+class MetricsWebContentsObserverTest : public ChromeRenderViewHostTestHarness {
public:
MetricsWebContentsObserverTest() : num_errors_(0) {}
void SetUp() override {
- RenderViewHostTestHarness::SetUp();
+ ChromeRenderViewHostTestHarness::SetUp();
AttachObserver();
}
@@ -469,8 +469,7 @@ TEST_F(MetricsWebContentsObserverTest, LogAbortChainsNoCommit) {
web_contents()->Stop();
histogram_tester_.ExpectTotalCount(internal::kAbortChainSizeNoCommit, 1);
- histogram_tester_.ExpectBucketCount(internal::kAbortChainSizeNoCommit, 3,
- 1);
+ histogram_tester_.ExpectBucketCount(internal::kAbortChainSizeNoCommit, 3, 1);
}
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698