Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: components/page_load_metrics/browser/page_load_metrics_util.h

Issue 2177743002: Migrate page_load_metrics out of components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: migrate page_load_metrics_messages to common message generator Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/page_load_metrics_util.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_util.h b/components/page_load_metrics/browser/page_load_metrics_util.h
deleted file mode 100644
index dfeeabdb14693c1890c307db89b874bb2813f4e1..0000000000000000000000000000000000000000
--- a/components/page_load_metrics/browser/page_load_metrics_util.h
+++ /dev/null
@@ -1,45 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_
-#define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_
-
-#include "base/metrics/histogram_macros.h"
-#include "base/optional.h"
-#include "base/time/time.h"
-
-#define PAGE_LOAD_HISTOGRAM(name, sample) \
- UMA_HISTOGRAM_CUSTOM_TIMES(name, sample, \
- base::TimeDelta::FromMilliseconds(10), \
- base::TimeDelta::FromMinutes(10), 100)
-
-namespace page_load_metrics {
-
-struct PageLoadExtraInfo;
-struct PageLoadTiming;
-
-// Returns true if:
-// - We have timing information for the event.
-// - The page load started while the page was in the foreground.
-// - The event occurred prior to the page being moved to the background.
-// When a page is backgrounded, some events (e.g. paint) are delayed. Since
-// these data points can skew the mean, they should not be mixed with timing
-// events that occurred in the foreground.
-// If the event time delta and background time delta are equal, we still
-// consider the event to be logged in the foreground histogram since any
-// background specific handling would not yet have been applied to that event.
-bool WasStartedInForegroundOptionalEventInForeground(
- const base::Optional<base::TimeDelta>& event,
- const PageLoadExtraInfo& info);
-
-// Returns true if:
-// - Parse started and did not complete but the entire page load duration
-// happened in the foreground.
-// - Parse completed and happened entirely in the foreground.
-bool WasParseInForeground(const base::Optional<base::TimeDelta>& parse_start,
- const base::Optional<base::TimeDelta>& parse_stop,
- const PageLoadExtraInfo& info);
-} // namespace page_load_metrics
-
-#endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698