Migrate page_load_metrics out of components.

Migrate page_load_metrics out of components.

There's an effort underway to trim down components
(https://bugs.chromium.org/p/chromium/issues/detail?id=624590).

As part of this effort, we're moving the page_load_metrics component
to chrome/.

This change moves code out of components like so:
components/page_load_metrics/browser -> chrome/browser/page_load_metrics
components/page_load_metrics/renderer -> chrome/renderer/page_load_metrics
components/page_load_metrics/common -> chrome/common/page_load_metrics

This change does not include any logic changes - it just moves code
to its new home, updates includes and build dependencies, etc.

BUG=630837
Committed: https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0
Cr-Commit-Position: refs/heads/master@{#407966}

[Bryan McQuade, 2016-07-23 13:30:54]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 13:31:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-07-23 13:38:15]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 13:38:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-07-23 13:43:39]

Description was changed from

==========
Migrate page_load_metrics out of components.

BUG=
==========

to

==========
Migrate page_load_metrics out of components.

BUG=630837
==========

[Bryan McQuade, 2016-07-23 13:44:15]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 13:44:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 13:50:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 13:50:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[Bryan McQuade, 2016-07-23 13:51:25]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 13:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-07-23 13:56:03]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 13:56:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 14:23:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 14:23:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bryan McQuade, 2016-07-23 15:00:42]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 15:01:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 16:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 16:05:50]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-07-23 16:15:58]

Description was changed from

==========
Migrate page_load_metrics out of components.

BUG=630837
==========

to

==========
Migrate page_load_metrics out of components.

There's an effort underway to trim down components
(https://bugs.chromium.org/p/chromium/issues/detail?id=624590).

As part of this effort, we're moving the page_load_metrics component
to chrome/.

This change moves code out of components like so:
components/page_load_metrics/browser -> chrome/browser/page_load_metrics
components/page_load_metrics/renderer -> chrome/renderer/page_load_metrics
components/page_load_metrics/common -> chrome/common/page_load_metrics

BUG=630837
==========

[Bryan McQuade, 2016-07-23 16:16:38]

Description was changed from

==========
Migrate page_load_metrics out of components.

There's an effort underway to trim down components
(https://bugs.chromium.org/p/chromium/issues/detail?id=624590).

As part of this effort, we're moving the page_load_metrics component
to chrome/.

This change moves code out of components like so:
components/page_load_metrics/browser -> chrome/browser/page_load_metrics
components/page_load_metrics/renderer -> chrome/renderer/page_load_metrics
components/page_load_metrics/common -> chrome/common/page_load_metrics

BUG=630837
==========

to

==========
Migrate page_load_metrics out of components.

There's an effort underway to trim down components
(https://bugs.chromium.org/p/chromium/issues/detail?id=624590).

As part of this effort, we're moving the page_load_metrics component
to chrome/.

This change moves code out of components like so:
components/page_load_metrics/browser -> chrome/browser/page_load_metrics
components/page_load_metrics/renderer -> chrome/renderer/page_load_metrics
components/page_load_metrics/common -> chrome/common/page_load_metrics

This change does not include any logic changes - it's just moving code
around, updating includes and build dependencies, etc.

BUG=630837
==========

[Bryan McQuade, 2016-07-23 16:16:57]

Description was changed from

==========
Migrate page_load_metrics out of components.

There's an effort underway to trim down components
(https://bugs.chromium.org/p/chromium/issues/detail?id=624590).

As part of this effort, we're moving the page_load_metrics component
to chrome/.

This change moves code out of components like so:
components/page_load_metrics/browser -> chrome/browser/page_load_metrics
components/page_load_metrics/renderer -> chrome/renderer/page_load_metrics
components/page_load_metrics/common -> chrome/common/page_load_metrics

This change does not include any logic changes - it's just moving code
around, updating includes and build dependencies, etc.

BUG=630837
==========

to

==========
Migrate page_load_metrics out of components.

There's an effort underway to trim down components
(https://bugs.chromium.org/p/chromium/issues/detail?id=624590).

As part of this effort, we're moving the page_load_metrics component
to chrome/.

This change moves code out of components like so:
components/page_load_metrics/browser -> chrome/browser/page_load_metrics
components/page_load_metrics/renderer -> chrome/renderer/page_load_metrics
components/page_load_metrics/common -> chrome/common/page_load_metrics

This change does not include any logic changes - it just moves code
to its new home, updates includes and build dependencies, etc.

BUG=630837
==========

[Bryan McQuade, 2016-07-23 16:22:04]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[Bryan McQuade, 2016-07-23 16:22:30]

PTAL, thanks! Once we're happy with the change, I'll add additional owners.

[blundell, 2016-07-24 17:39:47]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2016-07-24 17:39:48]

drive-by: It's plausible to me that we'd be interested in tracking metrics for
page loads in Android WebView. Is that not going to be the case in any kind of
near-term future?

[Bryan McQuade, 2016-07-24 21:29:49]

On 2016/07/24 at 17:39:48, blundell wrote:
> drive-by: It's plausible to me that we'd be interested in tracking metrics for
page loads in Android WebView. Is that not going to be the case in any kind of
near-term future?

Thanks - good question. I think we might want to track perf for webview, though
I need to think about it a bit more to be sure. Architecturally, where would
this code need to live in order to be used to track webview page load perf? Does
webview link in any of the code in chrome/?

[blundell, 2016-07-25 05:28:24]

On 2016/07/24 21:29:49, Bryan McQuade wrote:
> On 2016/07/24 at 17:39:48, blundell wrote:
> > drive-by: It's plausible to me that we'd be interested in tracking metrics
for
> page loads in Android WebView. Is that not going to be the case in any kind of
> near-term future?
> 
> Thanks - good question. I think we might want to track perf for webview,
though
> I need to think about it a bit more to be sure. Architecturally, where would
> this code need to live in order to be used to track webview page load perf?
Does
> webview link in any of the code in chrome/?

webview is a distinct embedder of //components from //chrome. So it could share
the code in //components and would need to have its own version of the code in
//chrome. That's the reason I raise the question :).

[Bryan McQuade, 2016-07-25 10:23:51]

On 2016/07/25 at 05:28:24, blundell wrote:
> On 2016/07/24 21:29:49, Bryan McQuade wrote:
> > On 2016/07/24 at 17:39:48, blundell wrote:
> > > drive-by: It's plausible to me that we'd be interested in tracking metrics
for
> > page loads in Android WebView. Is that not going to be the case in any kind
of
> > near-term future?
> > 
> > Thanks - good question. I think we might want to track perf for webview,
though
> > I need to think about it a bit more to be sure. Architecturally, where would
> > this code need to live in order to be used to track webview page load perf?
Does
> > webview link in any of the code in chrome/?
> 
> webview is a distinct embedder of //components from //chrome. So it could
share the code in //components and would need to have its own version of the
code in //chrome. That's the reason I raise the question :).

Ah, thanks, makes sense. I spent some time learning more about how webview is
used, and I'm less sure it'd be useful to track page load metrics for webview.
One common use case is to serve and display ads in a webview, and another is to
host apps written with web tech to give them a native feel. Given these use
cases are quite different from the use cases we're focusing on (web page content
loaded over the network) and given that ads and web apps have different loading
characteristics but would be mixed together among all webview metrics, I'm
disinclined to track page load metrics for webview for the time being. I don't
know that it'll be useful for us. WDYT? Do you see other reasons that we should
track page load metrics for webview?

[blundell, 2016-07-25 10:39:16]

On 2016/07/25 10:23:51, Bryan McQuade wrote:
> On 2016/07/25 at 05:28:24, blundell wrote:
> > On 2016/07/24 21:29:49, Bryan McQuade wrote:
> > > On 2016/07/24 at 17:39:48, blundell wrote:
> > > > drive-by: It's plausible to me that we'd be interested in tracking
metrics
> for
> > > page loads in Android WebView. Is that not going to be the case in any
kind
> of
> > > near-term future?
> > > 
> > > Thanks - good question. I think we might want to track perf for webview,
> though
> > > I need to think about it a bit more to be sure. Architecturally, where
would
> > > this code need to live in order to be used to track webview page load
perf?
> Does
> > > webview link in any of the code in chrome/?
> > 
> > webview is a distinct embedder of //components from //chrome. So it could
> share the code in //components and would need to have its own version of the
> code in //chrome. That's the reason I raise the question :).
> 
> Ah, thanks, makes sense. I spent some time learning more about how webview is
> used, and I'm less sure it'd be useful to track page load metrics for webview.
> One common use case is to serve and display ads in a webview, and another is
to
> host apps written with web tech to give them a native feel. Given these use
> cases are quite different from the use cases we're focusing on (web page
content
> loaded over the network) and given that ads and web apps have different
loading
> characteristics but would be mixed together among all webview metrics, I'm
> disinclined to track page load metrics for webview for the time being. I don't
> know that it'll be useful for us. WDYT? Do you see other reasons that we
should
> track page load metrics for webview?

Nope, your reasoning sounds good to me! Just wanted to double-check to avoid
churn.

[Charlie Harrison, 2016-07-25 16:19:07]

LGTM

[Bryan McQuade, 2016-07-25 17:56:16]

bmcquade@chromium.org changed reviewers:
+ jam@chromium.org

[Bryan McQuade, 2016-07-25 17:57:26]

bmcquade@chromium.org changed reviewers:
+ tsepez@chromium.org
- jam@chromium.org

[Bryan McQuade, 2016-07-25 17:59:20]

+tsepez for tools/ipc_fuzzer and chrome/common/page_load_metrics.

Tom, there aren't any real functionality changes here. I'm just moving code from
components/ to chrome/, but I thought it'd be good to get your review for the
IPC related parts just to be safe. Thanks!

[Tom Sepez, 2016-07-25 18:10:00]

messages LGTM. Thanks for the heads-up.

[Bryan McQuade, 2016-07-25 18:12:12]

bmcquade@chromium.org changed reviewers:
+ jam@chromium.org

[Bryan McQuade, 2016-07-25 18:12:24]

bmcquade@chromium.org changed reviewers:
- blundell@chromium.org

[Bryan McQuade, 2016-07-25 18:29:55]

jam, here's the refactor to move components/page_load_metrics/ to chrome/. Can
you review for addition of the new chrome/common/page_load_metrics and
chrome/renderer/page_load_metrics directories, as well as changes to gypi and
BUILD.gn files?

[jam, 2016-07-25 19:20:40]

lgtm, thank you

[Bryan McQuade, 2016-07-25 23:45:45]

The CQ bit was checked by bmcquade@chromium.org

[commit-bot: I haz the power, 2016-07-25 23:46:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 23:50:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 23:50:57]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bryan McQuade, 2016-07-26 01:18:17]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 01:18:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 01:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 01:28:24]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Bryan McQuade, 2016-07-26 20:01:51]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 20:02:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 20:21:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 20:21:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bryan McQuade, 2016-07-26 21:17:55]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 21:18:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 22:51:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 22:51:17]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-07-26 22:59:16]

tsepez, could you take one more pass on the IPC changes? I made a few small
changes based on our email discussion. Thanks!

https://codereview.chromium.org/2177743002/diff/140001/tools/ipc_fuzzer/messa...
File tools/ipc_fuzzer/message_lib/OWNERS (right):

https://codereview.chromium.org/2177743002/diff/140001/tools/ipc_fuzzer/messa...
tools/ipc_fuzzer/message_lib/OWNERS:1: per-file *_messages*.h=set noparent
Per discussion with tsepez, I added this to address a presubmit warning.

https://codereview.chromium.org/2177743002/diff/140001/tools/ipc_fuzzer/messa...
File tools/ipc_fuzzer/message_lib/all_messages.h (left):

https://codereview.chromium.org/2177743002/diff/140001/tools/ipc_fuzzer/messa...
tools/ipc_fuzzer/message_lib/all_messages.h:24: #include
"components/page_load_metrics/common/page_load_metrics_messages.h"
Per discussion with tsepez, I moved this to
chrome/common/common_message_generator.h

[Tom Sepez, 2016-07-26 23:03:06]

lgtm

[Bryan McQuade, 2016-07-26 23:26:52]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-07-26 23:26:53]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2177743002/#ps160001
(title: "migrate page_load_metrics_messages to common message generator")

[commit-bot: I haz the power, 2016-07-26 23:27:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 23:34:08]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-26 23:36:34]

Description was changed from

==========
Migrate page_load_metrics out of components.

There's an effort underway to trim down components
(https://bugs.chromium.org/p/chromium/issues/detail?id=624590).

As part of this effort, we're moving the page_load_metrics component
to chrome/.

This change moves code out of components like so:
components/page_load_metrics/browser -> chrome/browser/page_load_metrics
components/page_load_metrics/renderer -> chrome/renderer/page_load_metrics
components/page_load_metrics/common -> chrome/common/page_load_metrics

This change does not include any logic changes - it just moves code
to its new home, updates includes and build dependencies, etc.

BUG=630837
==========

to

==========
Migrate page_load_metrics out of components.

There's an effort underway to trim down components
(https://bugs.chromium.org/p/chromium/issues/detail?id=624590).

As part of this effort, we're moving the page_load_metrics component
to chrome/.

This change moves code out of components like so:
components/page_load_metrics/browser -> chrome/browser/page_load_metrics
components/page_load_metrics/renderer -> chrome/renderer/page_load_metrics
components/page_load_metrics/common -> chrome/common/page_load_metrics

This change does not include any logic changes - it just moves code
to its new home, updates includes and build dependencies, etc.

BUG=630837

Committed: https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0
Cr-Commit-Position: refs/heads/master@{#407966}
==========

[commit-bot: I haz the power, 2016-07-26 23:36:35]

Patchset 9 (id:??) landed as
https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0
Cr-Commit-Position: refs/heads/master@{#407966}