Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2177733002: Revert of Fix typo in printing.gyp (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
emircan, skau
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix typo in printing.gyp (patchset #3 id:40001 of https://codereview.chromium.org/2170123003/ ) Reason for revert: Broke "Win8 GYP (dbg)" bot. https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/978 python.exe gyp-win-tool link-with-manifests environment.x86 True initial\chrome.dll error LNK2005: "public: static class scoped_refptr<class cloud_print::PrintSystem> __cdecl cloud_print::PrintSystem::CreateInstance(...) initial\chrome.dll : fatal error LNK1169: one or more multiply defined symbols found Original issue's description: > Fix GYP build for Chrome OS to match GN > > Fix type in printing.gyp: printing/backend/cups_deleter{,s}.{h,cc} > > Disable the cloud print connector like in GN in chrome.gyp > > BUG=630791 > > TEST=Ran `GYP_CHROMIUM_NO_ACTION=0 gclient sync` and verified that chrome compiles > > Committed: https://crrev.com/d9e819815d379eb2492514ddb8158def89314311 > Cr-Commit-Position: refs/heads/master@{#407317} TBR=emircan@chromium.org,skau@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630791 Committed: https://crrev.com/a8c0d1b355e27b72c44d197cc3e1c11e1eb69a56 Cr-Commit-Position: refs/heads/master@{#407330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M chrome/chrome.gyp View 2 chunks +6 lines, -6 lines 0 comments Download
M printing/printing.gyp View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Lei Zhang
Created Revert of Fix typo in printing.gyp
4 years, 5 months ago (2016-07-23 02:54:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177733002/1
4 years, 5 months ago (2016-07-23 02:55:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-23 02:55:57 UTC) #7
Lei Zhang
Closing because https://codereview.chromium.org/2173283002/ beat me by ~1 minute.
4 years, 5 months ago (2016-07-23 02:56:00 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 02:57:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8c0d1b355e27b72c44d197cc3e1c11e1eb69a56
Cr-Commit-Position: refs/heads/master@{#407330}

Powered by Google App Engine
This is Rietveld 408576698