DescriptionRevert of Fix typo in printing.gyp (patchset #3 id:40001 of https://codereview.chromium.org/2170123003/ )
Reason for revert:
Broke "Win8 GYP (dbg)" bot.
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/978
python.exe gyp-win-tool link-with-manifests environment.x86 True initial\chrome.dll
error LNK2005: "public: static class scoped_refptr<class cloud_print::PrintSystem> __cdecl cloud_print::PrintSystem::CreateInstance(...)
initial\chrome.dll : fatal error LNK1169: one or more multiply defined symbols found
Original issue's description:
> Fix GYP build for Chrome OS to match GN
>
> Fix type in printing.gyp: printing/backend/cups_deleter{,s}.{h,cc}
>
> Disable the cloud print connector like in GN in chrome.gyp
>
> BUG=630791
>
> TEST=Ran `GYP_CHROMIUM_NO_ACTION=0 gclient sync` and verified that chrome compiles
>
> Committed: https://crrev.com/d9e819815d379eb2492514ddb8158def89314311
> Cr-Commit-Position: refs/heads/master@{#407317}
TBR=emircan@chromium.org,skau@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630791
Committed: https://crrev.com/a8c0d1b355e27b72c44d197cc3e1c11e1eb69a56
Cr-Commit-Position: refs/heads/master@{#407330}
Patch Set 1 #
Messages
Total messages: 10 (5 generated)
|