DevTools: [Android] implement RenderWidgetHostViewAndroid::CopyFromCompositingSurface

content/browser/android/content_view_core_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_view_core_impl.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
@@ skipping 43 matching lines @@
 #include "ui/gfx/screen.h"
 #include "ui/gfx/size_conversions.h"
 #include "ui/gfx/size_f.h"
 #include "webkit/common/user_agent/user_agent_util.h"
 
 using base::android::AttachCurrentThread;
 using base::android::ConvertJavaStringToUTF16;
 using base::android::ConvertJavaStringToUTF8;
 using base::android::ConvertUTF16ToJavaString;
 using base::android::ConvertUTF8ToJavaString;
+using base::android::HasException;
+using base::android::JavaByteArrayToByteVector;
 using base::android::ScopedJavaGlobalRef;
 using base::android::ScopedJavaLocalRef;
 using WebKit::WebGestureEvent;
 using WebKit::WebInputEvent;
 
 // Describes the type and enabled state of a select popup item.
 // Keep in sync with the value defined in SelectPopupDialog.java
 enum PopupItemType {
   POPUP_ITEM_TYPE_GROUP = 0,
   POPUP_ITEM_TYPE_DISABLED,
@@ skipping 626 matching lines @@
 }
 
 void ContentViewCoreImpl::SetNeedsAnimate() {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
   if (obj.is_null())
     return;
   Java_ContentViewCore_setNeedsAnimate(env, obj.obj());
 }
 
+bool ContentViewCoreImpl::GrabSnapshot(const std::string& format,
+                                       int quality,
+                                       double scale,
+                                       std::vector<uint8>* data) {
+  gfx::Size size = gfx::ToFlooredSize(gfx::ScaleSize(GetViewportSizePix(),
+                                                     scale));

[Sami, 2013/08/05 16:56:15]

Check that no dimension of |size| is zero here.

+  SkBitmap bitmap;

[Sami, 2013/08/05 16:56:15]

To avoid the extra allocation and copy on line 735, let's flip this around so
that we allocate the java bitmap from the beginning and point
PopulateBitmapWithContents directly into it. Something like this:

    jobject bitmapObject = <call into java to create a bitmap of the right size>
    gfx::JavaBitmap javaBitmap(bitmapObject);
    SkBitmap bitmap;
    bitmap.setConfig(SkBitmap::kARGB_8888_Config, size.width(), size.height());
    bitmap.setPixels(javaBitmap.pixels());
    // call PopulateBitmapWithContents as below

Make sure you destroy |javaBitmap| before try compressing the Java bitmap.

+  bitmap.setConfig(SkBitmap::kARGB_8888_Config, size.width(), size.height());
+  bitmap.allocPixels();
+  SkAutoLockPixels lock(bitmap);
+
+  RenderWidgetHostViewAndroid* view = GetRenderWidgetHostViewAndroid();
+  if (!view->PopulateBitmapWithContents(size, &bitmap))

[no sievers, 2013/08/05 21:46:44]

We'd like to deprecate this API and make all readbacks asynchronous. Essentially
you invoke the readback and you'd eventually get a callback that passes you an
SkBitmap.

I think crbug.com/252037 tracks that for GrabWindow/ViewSnapshot().

+    return false;
+
+  JNIEnv* env = AttachCurrentThread();
+  ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
+  if (obj.is_null())
+    return false;
+
+  ScopedJavaLocalRef<jstring> jstring_format =
+      ConvertUTF8ToJavaString(env, format);
+  ScopedJavaLocalRef<jobject> java_bitmap =
+      gfx::ConvertToJavaBitmap(&bitmap);
+  DCHECK(!java_bitmap.is_null());
+
+  ScopedJavaLocalRef<jbyteArray> data_ref =
+      Java_ContentViewCore_compressBitmap(env, obj.obj(), java_bitmap.obj(),
+                                          jstring_format.obj(), quality);
+  if (HasException(env) || data_ref.is_null())
+    return false;
+
+  JavaByteArrayToByteVector(env, data_ref.obj(), data);
+  return true;
+}
+
 ui::ViewAndroid* ContentViewCoreImpl::GetViewAndroid() const {
   // view_android_ should never be null for Chrome.
   DCHECK(view_android_);
   return view_android_;
 }
 
 ui::WindowAndroid* ContentViewCoreImpl::GetWindowAndroid() const {
   // This should never be NULL for Chrome, but will be NULL for WebView.
   DCHECK(window_android_);
   return window_android_;
@@ skipping 874 matching lines @@
       reinterpret_cast<ui::ViewAndroid*>(view_android),
       reinterpret_cast<ui::WindowAndroid*>(window_android));
   return reinterpret_cast<jint>(view);
 }
 
 bool RegisterContentViewCore(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content