Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc

Issue 2177663002: mash: Move ownership of ShelfDelegate to WmShell (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix wallpaper tests again Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/arc_auth_service.cc ('k') | chrome/browser/extensions/bookmark_app_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
index bd3d1d26e8184eb5ec1826e4dea14af6d77aca24..4ff24e6cfa629c0a9b6e0e57eff7815fb4320d9d 100644
--- a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
+++ b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
@@ -6,6 +6,7 @@
#include <stddef.h>
+#include "ash/common/wm_shell.h"
#include "ash/desktop_background/desktop_background_controller.h"
#include "ash/desktop_background/desktop_background_controller_observer.h"
#include "ash/desktop_background/desktop_background_controller_test_api.h"
@@ -118,6 +119,9 @@ class WallpaperManagerBrowserTest : public InProcessBrowserTest {
void LogIn(const AccountId& account_id, const std::string& user_id_hash) {
user_manager::UserManager::Get()->UserLoggedIn(account_id, user_id_hash,
false);
+ // Adding a secondary display creates a shelf on that display, which
+ // assumes a shelf on the primary display if the user was logged in.
+ ash::Shell::GetInstance()->CreateShelf();
WaitAsyncWallpaperLoadStarted();
}
@@ -130,6 +134,11 @@ class WallpaperManagerBrowserTest : public InProcessBrowserTest {
user_manager::UserManager::Get()->FindUserAndModify(account_id);
user_manager::UserManager::Get()->ChangeUserChildStatus(
user, true /* is_child */);
+ // TODO(jamescook): For some reason creating the shelf here (which is what
+ // would happen in normal login) causes the child wallpaper tests to fail
+ // with the wallpaper having alpha. This looks like the wallpaper is mid-
+ // animation, but happens even if animations are disabled. Something is
+ // wrong with how these tests simulate login.
}
int LoadedWallpapers() {
« no previous file with comments | « chrome/browser/chromeos/arc/arc_auth_service.cc ('k') | chrome/browser/extensions/bookmark_app_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698