Fix std::string::assign invocation: pass string instead of char*.

Fix std::string::assign invocation: pass string instead of char*.

According to the C++ standard, the three arguments overload
of std::string::assign accepts an std::basic_string:
http://en.cppreference.com/w/cpp/string/basic_string/assign

Fixing the usage, where char* instead of std::string was passed.

This popped up after libc++ became more standard compliant,
and now it throws a compiler error.

BUG=630681
Committed: https://crrev.com/5c1cf32985988682e68bb3d695009086a314eb39
Cr-Commit-Position: refs/heads/master@{#407302}

[krasin1, 2016-07-22 21:23:34]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 21:24:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2016-07-22 21:28:59]

krasin@chromium.org changed reviewers:
+ pam@chromium.org

[krasin1, 2016-07-22 21:29:00]

Hi Pam,

please, take a look at this one-line fix. It should help unblocking the roll of
the new Clang version that includes a newer libc++ version, that has become more
strict about following the standard and that does not like this line (and for a
reason).

[Pam (message me for reviews), 2016-07-22 21:32:50]

On 2016/07/22 21:29:00, krasin1 wrote:
> Hi Pam,
> 
> please, take a look at this one-line fix. It should help unblocking the roll
of
> the new Clang version that includes a newer libc++ version, that has become
more
> strict about following the standard and that does not like this line (and for
a
> reason).

LGTM, thanks!

[krasin1, 2016-07-22 21:34:06]

Thank you for the instant review!

[krasin1, 2016-07-22 21:34:10]

The CQ bit was unchecked by krasin@chromium.org

[krasin1, 2016-07-22 21:34:14]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-07-22 21:34:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 23:43:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-22 23:44:35]

Description was changed from

==========
Fix std::string::assign invocation: pass string instead of char*.

According to the C++ standard, the three arguments overload
of std::string::assign accepts an std::basic_string:
http://en.cppreference.com/w/cpp/string/basic_string/assign

Fixing the usage, where char* instead of std::string was passed.

This popped up after libc++ became more standard compliant,
and now it throws a compiler error.

BUG=630681
==========

to

==========
Fix std::string::assign invocation: pass string instead of char*.

According to the C++ standard, the three arguments overload
of std::string::assign accepts an std::basic_string:
http://en.cppreference.com/w/cpp/string/basic_string/assign

Fixing the usage, where char* instead of std::string was passed.

This popped up after libc++ became more standard compliant,
and now it throws a compiler error.

BUG=630681

Committed: https://crrev.com/5c1cf32985988682e68bb3d695009086a314eb39
Cr-Commit-Position: refs/heads/master@{#407302}
==========

[commit-bot: I haz the power, 2016-07-22 23:44:36]

Patchset 1 (id:??) landed as
https://crrev.com/5c1cf32985988682e68bb3d695009086a314eb39
Cr-Commit-Position: refs/heads/master@{#407302}