Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 21776002: Make optimized debug builds link against debug CRT. (Closed)

Created:
7 years, 4 months ago by Michael Achenbach
Modified:
7 years, 4 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Make optimized debug builds link against debug CRT. We recently had some XP issues on chromium.win after https://codereview.chromium.org/19384011/. This might fix it - quote: "The most likely cause of the problem is a gyp (or similar) change that resulted in v8.dll linking against the release version of the crt (for a debug build). There are two MS VC related files: the crt and the c++ std lib (MSVCR100.DLL and MSVCP100D.DLL). The former is set to release, the latter to debug." I am not entirely sure if this change fits to the linker options for debug level 2. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/toolchain.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
lgtm
7 years, 4 months ago (2013-08-02 09:05:41 UTC) #1
Michael Achenbach
Committed patchset #1 manually as r16026 (presubmit successful).
7 years, 4 months ago (2013-08-02 10:59:31 UTC) #2
Dirk Pranke
7 years, 4 months ago (2013-08-02 18:19:07 UTC) #3
Message was sent while issue was closed.
On 2013/08/02 10:59:31, machenbach wrote:
> Committed patchset #1 manually as r16026 (presubmit successful).

We're not yet using v8_optimized_debug=2 in chromium, so I doubt this change
would have any effect. Regardless, I think it is the right thing to do (I've
been worried about this and meaning to test it myself but didn't have time over
the past couple days). I will definitely be poking at this today.

Powered by Google App Engine
This is Rietveld 408576698