Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2177563002: [Mac] "Report an Issue" menu item should be enabled when Task Manager is focused (Closed)

Created:
4 years, 5 months ago by Sungmann Cho
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] "Report an Issue" menu item should be enabled when Task Manager is focused Currently, the official build always disable "Report an Issue" menu item through -[AppController validateUserInterfaceItem:], when Task Manager is opened and focused. This code was added at https://codereview.chromium.org/7635017. I can't find any discussion of this behaviour, but I think users should be able to report their problems at any time without any difficulties. BUG=526531 Committed: https://crrev.com/440a7e5499ad508701460663f4bd296a0b943948 Cr-Commit-Position: refs/heads/master@{#407604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sungmann Cho
Please take a look. Thanks!
4 years, 5 months ago (2016-07-22 17:11:42 UTC) #3
Robert Sesek
LGTM. But, please replace "AppController::validateUserInterfaceItem()" with "-[AppController validateUserInterfaceItem:]" in the CL description, though. The former ...
4 years, 5 months ago (2016-07-25 18:10:27 UTC) #4
Sungmann Cho
On 2016/07/25 18:10:27, Robert Sesek wrote: > LGTM. But, please replace "AppController::validateUserInterfaceItem()" with > "-[AppController ...
4 years, 5 months ago (2016-07-25 21:24:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177563002/1
4 years, 5 months ago (2016-07-25 21:25:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 21:56:48 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:59:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/440a7e5499ad508701460663f4bd296a0b943948
Cr-Commit-Position: refs/heads/master@{#407604}

Powered by Google App Engine
This is Rietveld 408576698